ConcretizationCache: do not enforce absolute paths for cache entry locks#51465
Merged
alalazo merged 1 commit intospack:developfrom Oct 23, 2025
Merged
Conversation
Signed-off-by: John Parent <[email protected]>
6 tasks
alalazo
approved these changes
Oct 23, 2025
alalazo
approved these changes
Oct 23, 2025
Member
|
Confirmed that this fixed the builds on Windows: https://gitlab.spack.io/spack/spack-packages/-/pipelines/1279941 |
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
Nov 4, 2025
…cks (spack#51465) Signed-off-by: John Parent <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #50905 (comment) there is an issue with requiring absolute paths here on Windows.
I believe at one point in the history of the conc cache this was required but is no longer (afaict) after a series of refactors. Remove it so we can avoid these build failures on Windows Gitlab CI
Edit: I think I recall why we were using abs paths, they became unnecessary when we switched to range based locking.
cc @alalazo @tgamblin