Conversation
68e7246 to
234a6d3
Compare
- [x] add a `DeprecatedStoreTrueAction` to our common arguments code - [x] use it in `spack info` - [x] update the test for `spack info` to ensure the warning Signed-off-by: Todd Gamblin <[email protected]>
- [x] document max_name_len argument to _print_definition - [x] remove unused type variables - [x] make a comment a bit more future-proof Signed-off-by: Todd Gamblin <[email protected]>
234a6d3 to
353e909
Compare
alalazo
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits add some cleanup items requested by @alalazo on #51137.
I noticed that in 3.13, argparse actually added a
deprecated=Trueoption to arguments, but we can't use that yet since 3.13 is too new. I added aDeprecatedStoreTrueActiontospack.cmd.common.argumentshere that we can use to deprecate arguments (and I suppose we can generalize it for other actions later). It does more than thedeprecated=True, e.g.:and prints: