concretization cache: further simplify locking and fetch code#51448
Merged
concretization cache: further simplify locking and fetch code#51448
Conversation
the ConcretizationCache, enabled in #50905, could still use a few more simplifications. - [x] Use `len` instead of `sum(1 ...)` - [x] Use `WriteTransaction` and `ReadTransaction` context managers instead of reimplementing. - [x] Clean up fetch a bit for better control flow Signed-off-by: Todd Gamblin <[email protected]>
alalazo
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ConcretizationCache, enabled in #50905, could still use a few more simplifications.
leninstead ofsum(1 ...)WriteTransactionandReadTransactioncontext managers instead of reimplementing.