Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
@haampie how about |
083c883 to
e712564
Compare
91b1770 to
9ce4c56
Compare
Member
Author
|
Rewiring jobs, locking for concurrent spack processes, and overwrite installs will have to wait for Spack v1.2, I won't get that done before v1.1. |
Merged
becker33
requested changes
Nov 4, 2025
Member
becker33
left a comment
There was a problem hiding this comment.
Hopefully this isn't too far out of date from whatever changes you made while I was reviewing it this morning/early afternoon
3f022f5 to
fc8d6e7
Compare
Member
Author
|
The last commit adds a search mode for the overview display so you can more easily follow logs of a specific build.
|
a2b2a39 to
9ffe671
Compare
becker33
requested changes
Nov 6, 2025
Member
becker33
left a comment
There was a problem hiding this comment.
Everything prior to the new search mode LGTM now, couple comments on the new code.
becker33
previously approved these changes
Nov 6, 2025
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
0f1b942 to
7ec402a
Compare
becker33
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
The new installer is experimental and not feature-complete. See #51515.
New, experimental console UI for the Spack installer that allows:
Demo: https://asciinema.org/a/7azU9idEnT8ydgxcRKxYBZzI2
Usage:
config:installertonew(or usespack -c config:installer:new install ...)-jflag inspack install -j <N> ...is all you need, it will build packages in parallel. The-pflag has no effect.Current features:
pstree <python pid>, it seems to work--jobserver-auth=R,Wpipes open in the subprocess in build processes in case Spack itself runs under an existing jobserverMAKEFLAGSin a subprocess based on thegmakeversion of the particular build: ifgmakeis new enough, pass the FIFO auth flag, if gmake is old, pass the file descriptors for the FIFO instead of the FIFO path.SIGCHLDto deal with build success/failure2>&1redirected)"1"/"0"bytes from "control" pipe from parent to toggle writing to parent pipe<n> more...on small terminalsredrawcalls