Skip to content

solver: reduce duplication of internal state#51361

Merged
haampie merged 2 commits intospack:developfrom
alalazo:solver/reduce-duplicate-internal-states
Sep 25, 2025
Merged

solver: reduce duplication of internal state#51361
haampie merged 2 commits intospack:developfrom
alalazo:solver/reduce-duplicate-internal-states

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Sep 24, 2025

  • Fix an issue where virtual_build_requirement could be associated with the wrong duplicate of the virtual
  • Try to associate the best version with the first duplicate of a package
  • Preferred providers are associated with earlier duplicates

@alalazo alalazo force-pushed the solver/reduce-duplicate-internal-states branch from 2b1560f to 0f34545 Compare September 24, 2025 20:06
* Fix an issue where virtual_build_requirement could be
  associated with the wrong duplicate of the virtual
* Try to associate the best version with the first duplicate of
  a package
* Preferred providers are associated with earlier duplicates

Signed-off-by: Massimiliano Culpo <[email protected]>
@alalazo alalazo force-pushed the solver/reduce-duplicate-internal-states branch from 0f34545 to 15058a7 Compare September 24, 2025 20:07
Signed-off-by: Massimiliano Culpo <[email protected]>
@alalazo alalazo marked this pull request as ready for review September 24, 2025 21:25
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Sep 24, 2025

This reduces the number of answer sets that map to the same spec, but doesn't change the current benchmark significantly:

radiuss.onlyrules.csv
radiuss.develop.csv

comparison

@alalazo alalazo changed the title solver: reduce duplication of internal state and improve heuristics solver: reduce duplication of internal state Sep 24, 2025
@haampie haampie merged commit a89488c into spack:develop Sep 25, 2025
33 checks passed
@alalazo alalazo deleted the solver/reduce-duplicate-internal-states branch September 25, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants