solver: mutate deepcopied packages config#51355
Merged
Conversation
Signed-off-by: Harmen Stoppels <[email protected]>
alalazo
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #51350.
Fixes a bug where shallow-copied packages.yaml config was mutated as part of the solve, causing duplicate entries for glibc in the solver, leading to a multiple unique solutions ultimately mapping to the same concrete spec. This just means that the solver has to spend more time proving optimality.
spack.util.spack_yaml.deepcopy_as_builtinwhich takes ruamel.yaml objects and spits out a deep copy using native typesdict,list,int,float,boolandtype(None).spack.config.Configuration.deepcopy_as_builtin, which is likeget_config, except it is a deep copy with native types.spack.solver.runtimes.external_config_with_implicit_externals(which was renamed from_*).I think in the future the solver can just call
deepcopy_as_builtinand work with ordinary dicts, instead of all these inefficient subtypes of strings etc produced by ruamel.yaml.