solver: remove a special case for provider weighting#51347
Merged
haampie merged 3 commits intospack:developfrom Sep 23, 2025
Merged
solver: remove a special case for provider weighting#51347haampie merged 3 commits intospack:developfrom
haampie merged 3 commits intospack:developfrom
Conversation
With compilers treated as dependencies, this special case can lead to multiple optimal solutions, when two or more compilers are enforced via the input, or a requirement. Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]>
Member
|
Can you also fix the incorrect comment |
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Member
So, ~2% instead of 10% outliers for the reported keras case. I'll check what the single outlier is about |
haampie
approved these changes
Sep 23, 2025
Member
Author
I see this: when diffing optimal solution 10 with optimal solution 683. So the next hunt is on |
Member
|
So, looks like the 1 in a 50 slowdown is where it finds the optimal solution in reasonable time, but then takes a long time to prove optimality. Not sure how you'd troubleshoot that. |
becker33
pushed a commit
that referenced
this pull request
Jan 10, 2026
With compilers treated as dependencies, this special case can lead to multiple optimal solutions, when two or more compilers are enforced via the input, or a requirement. Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]>
Merged
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
With compilers treated as dependencies, this special case can lead to multiple optimal solutions, when two or more compilers are enforced via the input, or a requirement. Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 2, 2026
With compilers treated as dependencies, this special case can lead to multiple optimal solutions, when two or more compilers are enforced via the input, or a requirement. Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 2, 2026
With compilers treated as dependencies, this special case can lead to multiple optimal solutions, when two or more compilers are enforced via the input, or a requirement. Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 19, 2026
With compilers treated as dependencies, this special case can lead to multiple optimal solutions, when two or more compilers are enforced via the input, or a requirement. Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With compilers treated as dependencies, this special case can lead to multiple optimal solutions, when two or more compilers are enforced via the input, or a requirement.