solver: improve timeout handling and add Ctrl-C interrupt safety#51341
Merged
haampie merged 5 commits intospack:developfrom Sep 23, 2025
Merged
solver: improve timeout handling and add Ctrl-C interrupt safety#51341haampie merged 5 commits intospack:developfrom
haampie merged 5 commits intospack:developfrom
Conversation
Also, hope this solves a deadlock that sometimes happens. Signed-off-by: Massimiliano Culpo <[email protected]> Co-authored-by: Danny McClanahan <[email protected]>
alalazo
force-pushed
the
solver/ctrl-c-in-solver
branch
from
f9bc87f to
4c63f1d
Compare
Member
Author
|
@cosmicexplorer Thanks for the hints on using |
Contributor
cosmicexplorer
left a comment
cosmicexplorer
left a comment
There was a problem hiding this comment.
Full support to minimizing the complexity here. I may have a prototype of reading package facts in parallel soon, but repeatedly polling over blocking is all we need to do to fix the problem.
Co-authored-by: Danny McClanahan <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
approved these changes
Sep 23, 2025
Merged
becker33
pushed a commit
that referenced
this pull request
Jan 10, 2026
) Signed-off-by: Massimiliano Culpo <[email protected]> Co-authored-by: Danny McClanahan <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
…ck#51341) Signed-off-by: Massimiliano Culpo <[email protected]> Co-authored-by: Danny McClanahan <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 2, 2026
) Signed-off-by: Massimiliano Culpo <[email protected]> Co-authored-by: Danny McClanahan <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 2, 2026
) Signed-off-by: Massimiliano Culpo <[email protected]> Co-authored-by: Danny McClanahan <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 19, 2026
) Signed-off-by: Massimiliano Culpo <[email protected]> Co-authored-by: Danny McClanahan <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using Ctrl+C to stop Spack even in the middle of concretization.