Correct the external GPU SW doc#51315
Merged
haampie merged 2 commits intospack:developfrom Sep 17, 2025
Merged
Conversation
Fix two problems in the the external GPU documentation. 1) The llvm-amdgpu package was listed twice with searate content. If both are inserted into a packages.yaml file it ends up creating a duplicated key causing spack to stop. Delete the first one which doesn't seem to have the right data. 2) The second compiler definition for llvm-amdgpu has broken syntax It needs to have extra_attributes before defining the compilers. Signed-off-by: Ben Woodard <[email protected]>
haampie
reviewed
Sep 17, 2025
Signed-off-by: Harmen Stoppels <[email protected]>
haampie
approved these changes
Sep 17, 2025
becker33
pushed a commit
that referenced
this pull request
Jan 10, 2026
Fix two problems in the the external GPU documentation. 1) The llvm-amdgpu package was listed twice with searate content. If both are inserted into a packages.yaml file it ends up creating a duplicated key causing spack to stop. Delete the first one which doesn't seem to have the right data. 2) The second compiler definition for llvm-amdgpu has broken syntax It needs to have extra_attributes before defining the compilers. Signed-off-by: Ben Woodard <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]>
Merged
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
Fix two problems in the the external GPU documentation. 1) The llvm-amdgpu package was listed twice with searate content. If both are inserted into a packages.yaml file it ends up creating a duplicated key causing spack to stop. Delete the first one which doesn't seem to have the right data. 2) The second compiler definition for llvm-amdgpu has broken syntax It needs to have extra_attributes before defining the compilers. Signed-off-by: Ben Woodard <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 2, 2026
Fix two problems in the the external GPU documentation. 1) The llvm-amdgpu package was listed twice with searate content. If both are inserted into a packages.yaml file it ends up creating a duplicated key causing spack to stop. Delete the first one which doesn't seem to have the right data. 2) The second compiler definition for llvm-amdgpu has broken syntax It needs to have extra_attributes before defining the compilers. Signed-off-by: Ben Woodard <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 2, 2026
Fix two problems in the the external GPU documentation. 1) The llvm-amdgpu package was listed twice with searate content. If both are inserted into a packages.yaml file it ends up creating a duplicated key causing spack to stop. Delete the first one which doesn't seem to have the right data. 2) The second compiler definition for llvm-amdgpu has broken syntax It needs to have extra_attributes before defining the compilers. Signed-off-by: Ben Woodard <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 19, 2026
Fix two problems in the the external GPU documentation. 1) The llvm-amdgpu package was listed twice with searate content. If both are inserted into a packages.yaml file it ends up creating a duplicated key causing spack to stop. Delete the first one which doesn't seem to have the right data. 2) The second compiler definition for llvm-amdgpu has broken syntax It needs to have extra_attributes before defining the compilers. Signed-off-by: Ben Woodard <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two problems in the the external GPU documentation. 1) The llvm-amdgpu package was listed twice with searate content. If
both are inserted into a packages.yaml file it ends up creating a
duplicated key causing spack to stop. Delete the first one which
doesn't seem to have the right data.
2) The second compiler definition for llvm-amdgpu has broken syntax It
needs to have extra_attributes before defining the compilers.