Closed
Conversation
Signed-off-by: Harmen Stoppels <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting this as a PR to share what is needed to make
pick
gmake %c=gccinstead ofgmake %c=llvm.The changes in this PR are the minimum needed to make "preferred compilers" the tie-breaker.
But these change make existing tests fail (e.g.
foo %clangis expected to set%clangon deps too), so, that suggests that the penalty from requirements (on providers) should be in terms of count of parent packages using them instead of count of providers existing.Edit: Closed this as @alalazo has an implementation of the suggestion in the PR description.