Variants and fixes to thrift package#513
Merged
tgamblin merged 2 commits intospack:developfrom Mar 10, 2016
Merged
Conversation
|
|
||
| # Variant dependencies | ||
| extends('python', when='+python') | ||
| depends_on('python', when='+python') |
Member
There was a problem hiding this comment.
You can get rid of this line. According to the Spack documentation:
You can call either
depends_onorextendson any one package, but not both. For example you cannot bothdepends_on('python')andextends(python)in the same package.extendsimpliesdepends_on.
tgamblin
added a commit
that referenced
this pull request
Mar 10, 2016
Variants and fixes to thrift package
matz-e
added a commit
to matz-e/spack
that referenced
this pull request
Apr 27, 2020
Co-Authored-By: Matthias Wolf <[email protected]>
tldahlgren
reviewed
Jan 27, 2023
Comment on lines
+46
to
+50
| options.append('--with-java=%s' % ('yes' if '+java' in spec else 'no')) | ||
| options.append('--with-go=%s' % ('yes' if '+go' in spec else 'no')) | ||
| options.append('--with-lua=%s' % ('yes' if '+lua' in spec else 'no')) | ||
| options.append('--with-php=%s' % ('yes' if '+php' in spec else 'no')) | ||
| options.append('--with-qt4=%s' % ('yes' if '+qt4' in spec else 'no')) |
Contributor
There was a problem hiding this comment.
@tgamblin @alfredo-gimenez I don't see variants for these options. Am I missing something here?
climbfuji
added a commit
to climbfuji/spack
that referenced
this pull request
Feb 4, 2025
release/1.9.0: Bug fix in wgrib2: apply '-Wno-error=implicit-function-declaration' for LLVM clang
gartung
pushed a commit
to gartung/spack
that referenced
this pull request
Apr 25, 2025
shush "frontend" warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.