solver: allow preferences with provider details#51263
Merged
haampie merged 3 commits intospack:developfrom Sep 3, 2025
Merged
Conversation
fixes spack#51262 The main issue is a type, where we use `spec.name` instead of spec to construct a condition for the solver. Fixing that issue uncovered a new bug (a unit test was failing) related to adding flags to providers through a requirements on the virtual. That is also fixed here. Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
added
bugfix
Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
reviewed
Sep 2, 2025
Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
approved these changes
Sep 3, 2025
alalazo
added a commit
that referenced
this pull request
Sep 8, 2025
The main issue is a typo, where we use `spec.name` instead of spec to construct a condition for the solver. Also fixes a bug related to adding flags to providers through a requirement on the virtual. Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
pushed a commit
that referenced
this pull request
Sep 12, 2025
The main issue is a typo, where we use `spec.name` instead of spec to construct a condition for the solver. Also fixes a bug related to adding flags to providers through a requirement on the virtual. Signed-off-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #51262
The main issue is a typo, where we use
spec.nameinstead ofspecto construct a condition for the solver.Fixing that issue uncovered a new bug (a unit test was failing) related to adding flags to providers through a requirements on the virtual. That is also fixed here.