zsh: fix regression in spack env activate --prompt#51258
Merged
Conversation
The spack.llnl.util.tty.color._escape function started to output the literal characters `\` and `e` instead of the escape character. That leads to: ``` \e[0;0;92m[default]\e[0;0m √ spack % ``` instead of ``` [default] √ spack % ``` on macOS's default zsh. Signed-off-by: Harmen Stoppels <[email protected]>
tgamblin
approved these changes
Sep 1, 2025
alalazo
pushed a commit
that referenced
this pull request
Sep 8, 2025
The spack.llnl.util.tty.color._escape function started to output the literal characters `\` and `e` instead of the escape character. That leads to: ``` \e[0;0;92m[default]\e[0;0m √ spack % ``` instead of ``` [default] √ spack % ``` on macOS's default zsh. Signed-off-by: Harmen Stoppels <[email protected]>
haampie
added a commit
that referenced
this pull request
Sep 12, 2025
The spack.llnl.util.tty.color._escape function started to output the literal characters `\` and `e` instead of the escape character. That leads to: ``` \e[0;0;92m[default]\e[0;0m √ spack % ``` instead of ``` [default] √ spack % ``` on macOS's default zsh. Signed-off-by: Harmen Stoppels <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
spack.llnl.util.tty.color._escapefunction started to output theliteral characters
\andeinstead of the escape character.That leads to:
instead of
on macOS's default shell.
(I wonder how this went unnoticed since it regressed in April 2024 🤔 #43712)