Retain the "direct" attribute of deps in "when" context manager#51256
Closed
alalazo wants to merge 1 commit intospack:developfrom
Closed
Retain the "direct" attribute of deps in "when" context manager#51256alalazo wants to merge 1 commit intospack:developfrom
alalazo wants to merge 1 commit intospack:developfrom
Conversation
fixes spack#51248 The value of the "direct" attribute of dependencies is currently lost in "when" context managers. This PR fixes the issue and adds unit tests to prevent regressions Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
added
bugfix
Member
|
This does not close 51248 |
Member
Author
|
Changed to "refers to" 51248, but unclear to me if #51248 (comment) is relevant or why it was closed as outdated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refers #51248
The value of the "direct" attribute of dependencies is currently lost in "when" context managers. This PR fixes the issue and adds unit tests to prevent regressions
Currently, we can't use plain
Spec.constrainin directives, since that function triggers lookup of the repository being constructed to resolve virtual dependencies. I'll check if that logic can be simplified in a following PR, and keep this one just for the bug fix.