Skip to content

solver: adjust optimization weights for "when possible"#51226

Merged
haampie merged 2 commits intospack:developfrom
alalazo:solver/raise-when-possible-in-priority
Aug 27, 2025
Merged

solver: adjust optimization weights for "when possible"#51226
haampie merged 2 commits intospack:developfrom
alalazo:solver/raise-when-possible-in-priority

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Aug 26, 2025

fixes #51224

In this way trying to solve more input specs is at higher priority than trying to satisfy strong preferences or requirements.

This was an unwanted side effect of #44373

fixes spack#51224

In this way trying to solve more input specs is
at higher priority than trying to satisfy strong preferences
or requirements.

This was an unwanted side effect of spack#44373

Signed-off-by: Massimiliano Culpo <[email protected]>
@alalazo alalazo added bugfix Something wasn't working, here's a fix v1.0.2 PRs / Bug fixes to backport for v1.0.2 labels Aug 26, 2025
Copy link
Copy Markdown
Contributor

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, the concretization time went down from 21mins+ to just over 2mins. That's a game changer. Thanks!

Signed-off-by: Massimiliano Culpo <[email protected]>
@alalazo alalazo mentioned this pull request Aug 27, 2025
26 tasks
@haampie haampie merged commit f4e4a95 into spack:develop Aug 27, 2025
33 checks passed
@alalazo alalazo deleted the solver/raise-when-possible-in-priority branch August 27, 2025 07:02
climbfuji pushed a commit to climbfuji/spack that referenced this pull request Aug 27, 2025
In this way trying to solve more input specs is at higher priority than trying to satisfy strong preferences or requirements.

Fixes a regression introduced by spack#44373

Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo added a commit that referenced this pull request Sep 8, 2025
In this way trying to solve more input specs is at higher priority than trying to satisfy strong preferences or requirements.

Fixes a regression introduced by #44373

Signed-off-by: Massimiliano Culpo <[email protected]>
haampie pushed a commit that referenced this pull request Sep 12, 2025
In this way trying to solve more input specs is at higher priority than trying to satisfy strong preferences or requirements.

Fixes a regression introduced by #44373

Signed-off-by: Massimiliano Culpo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix v1.0.2 PRs / Bug fixes to backport for v1.0.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Concretizer slowdown from v0.23 -> v1.0.1

3 participants