Skip to content

solver: fix building the default compiler#51201

Merged
alalazo merged 1 commit intospack:developfrom
alalazo:bugfix/default-self-build-requirement
Aug 22, 2025
Merged

solver: fix building the default compiler#51201
alalazo merged 1 commit intospack:developfrom
alalazo:bugfix/default-self-build-requirement

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Aug 21, 2025

Without this tweak, a new version of the default compiler would be built with a non-default compiler, because of the "multiple nodes from same package" penalty. Thus, make an exception for that specific case.

Before:

$ spack -m spec gcc@14
 -   [email protected] build_system=generic languages:='c,c++,fortran' arch=linux-ubuntu20.04-icelake %c,[email protected]
 -       ^[email protected] build_system=generic arch=linux-ubuntu20.04-icelake 
[e]      ^[email protected] build_system=autotools arch=linux-ubuntu20.04-icelake 
[e]      ^[email protected]+clang~flang+lld build_system=generic arch=linux-ubuntu20.04-icelake 

After:

$ spack -m spec gcc@14
 -   [email protected] build_system=generic languages:='c,c++,fortran' arch=linux-ubuntu20.04-icelake %c,[email protected]
 -       ^[email protected] build_system=generic arch=linux-ubuntu20.04-icelake 
[e]      ^[email protected] build_system=generic languages:='c,c++,fortran' arch=linux-ubuntu20.04-icelake 
 -       ^[email protected] build_system=generic arch=linux-ubuntu20.04-icelake 
[e]      ^[email protected] build_system=autotools arch=linux-ubuntu20.04-icelake 

Without this tweak, a new version of the default compiler would
be built with a non-default compiler, because of the "multiple
nodes from same package" penalty.

Thus, make an exception for that specific case.

Signed-off-by: Massimiliano Culpo <[email protected]>
@alalazo alalazo added concretization bugfix Something wasn't working, here's a fix v1.0.2 PRs / Bug fixes to backport for v1.0.2 labels Aug 21, 2025
@haampie
Copy link
Copy Markdown
Member

haampie commented Aug 22, 2025

oof

@alalazo alalazo merged commit 871248d into spack:develop Aug 22, 2025
33 checks passed
@alalazo alalazo deleted the bugfix/default-self-build-requirement branch August 22, 2025 06:26
@alalazo alalazo mentioned this pull request Aug 22, 2025
26 tasks
alalazo added a commit that referenced this pull request Aug 22, 2025
Without this tweak, a new version of the default compiler would
be built with a non-default compiler, because of the "multiple
nodes from same package" penalty.

Thus, make an exception for that specific case.

Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo added a commit that referenced this pull request Aug 22, 2025
Without this tweak, a new version of the default compiler would
be built with a non-default compiler, because of the "multiple
nodes from same package" penalty.

Thus, make an exception for that specific case.

Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo added a commit that referenced this pull request Aug 22, 2025
Without this tweak, a new version of the default compiler would
be built with a non-default compiler, because of the "multiple
nodes from same package" penalty.

Thus, make an exception for that specific case.

Signed-off-by: Massimiliano Culpo <[email protected]>
haampie pushed a commit that referenced this pull request Sep 12, 2025
Without this tweak, a new version of the default compiler would
be built with a non-default compiler, because of the "multiple
nodes from same package" penalty.

Thus, make an exception for that specific case.

Signed-off-by: Massimiliano Culpo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix concretization v1.0.2 PRs / Bug fixes to backport for v1.0.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants