solver: improve how optimization is presented#51198
Merged
haampie merged 4 commits intospack:developfrom Aug 22, 2025
Merged
Conversation
Show optimization criteria in the same column, ordered by the most relevant to the least relevant. Color lines according to what they refer to. Signed-off-by: Massimiliano Culpo <[email protected]>
Member
|
instead of concrete it should say reused for consistency |
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Member
|
swap the value and criterion column and align prio right too :) and potentially grey out the entire line if zero? |
Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
approved these changes
Aug 22, 2025
Member
haampie
left a comment
haampie
left a comment
There was a problem hiding this comment.
Looks nice, on macOS bold white is somehow rendered red, which is actually not bad given it's a penalty.
climbfuji
pushed a commit
to climbfuji/spack
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
added a commit
that referenced
this pull request
Sep 8, 2025
Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
pushed a commit
that referenced
this pull request
Sep 12, 2025
Signed-off-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show optimization criteria in the same column, ordered by the most relevant to the least relevant. Color lines according to what they refer to. Highlight non-zero optimization values.