Includes: support git includes#51191
Merged
tgamblin merged 26 commits intospack:developfrom Oct 22, 2025
Merged
Conversation
tldahlgren
force-pushed
the
include_git_repo_paths
branch
from
a3d0fcf to
c251625
Compare
tldahlgren
changed the title
tldahlgren
force-pushed
the
include_git_repo_paths
branch
2 times, most recently
from
61448b8 to
3c9c953
Compare
tldahlgren
force-pushed
the
include_git_repo_paths
branch
4 times, most recently
from
3a3cb17 to
c930c2e
Compare
tldahlgren
force-pushed
the
include_git_repo_paths
branch
2 times, most recently
from
9531f43 to
c58bd51
Compare
22 tasks
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
tldahlgren
force-pushed
the
include_git_repo_paths
branch
from
9b5177e to
4340898
Compare
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
…d_path_git Signed-off-by: tldahlgren <[email protected]>
…included_path_conditional_bad_when Signed-off-by: tldahlgren <[email protected]>
tldahlgren
force-pushed
the
include_git_repo_paths
branch
from
4340898 to
89ef413
Compare
tldahlgren
added
wait-on-reviewers
tgamblin
requested changes
Oct 21, 2025
Member
tgamblin
left a comment
tgamblin
left a comment
There was a problem hiding this comment.
Minor change requests/refactors but this looks good to me! Thanks @tldahlgren!
tldahlgren
force-pushed
the
include_git_repo_paths
branch
2 times, most recently
from
8f3cb83 to
4239ebf
Compare
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
…r feedback Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
tldahlgren
force-pushed
the
include_git_repo_paths
branch
from
4239ebf to
0093a09
Compare
tgamblin
approved these changes
Oct 22, 2025
1 task
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
Nov 4, 2025
This PR allows the use of git options, like those supported for `repos.yaml`, in `include.yaml`. This has been tested manually using configuration files from `https://github.com/spack/spack-configs/tree/main/USC/config`. Example (from the updated docs): ``` include: - git: https://github.com/spack/spack-configs branch: main when: os == "centos7" paths: - USC/config/config.yaml - USC/config/packages.yaml ``` - [x] Add unit tests (at least of `git`) options (scopes) --------- Signed-off-by: tldahlgren <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the use of git options, like those supported for
repos.yaml, ininclude.yaml.This has been tested manually using configuration files from
https://github.com/spack/spack-configs/tree/main/USC/config.Example (from the updated docs):
TODO:
git) options (scopes)