solver: ensure commit variants enter dag hash#51190
Merged
psakievich merged 14 commits intospack:developfrom Aug 29, 2025
Merged
solver: ensure commit variants enter dag hash#51190psakievich merged 14 commits intospack:developfrom
psakievich merged 14 commits intospack:developfrom
Conversation
Resolves spack#51167 by moving the commit variant population before specs are finalized. Signed-off-by: psakiev <[email protected]>
psakievich
added
bugfix
Signed-off-by: psakiev <[email protected]>
Signed-off-by: psakiev <[email protected]>
Signed-off-by: psakiev <[email protected]>
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
lib/spack/spack/package_base.py
lib/spack/spack/solver/asp.py
lib/spack/spack/test/concretization/core.py
lib/spack/spack/test/conftest.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted lib/spack/spack/test/concretization/core.py
All done! ✨ 🍰 ✨
1 file reformatted, 3 files left unchanged.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 616 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
Signed-off-by: psakiev <[email protected]>
Signed-off-by: psakiev <[email protected]>
psakievich
force-pushed
the
hash-to-hash
branch
from
f3440a6 to
db06f87
Compare
haampie
added
v1.0.2
Member
|
FYI, if you need a feature backported, use one or more |
alalazo
previously requested changes
Aug 21, 2025
psakievich
commented
Aug 21, 2025
alalazo
reviewed
Aug 21, 2025
The stage check is no longer valid pre spec finalize. These unfinalized specs should never have the same stage since we are adding a variant for this method. Signed-off-by: psakiev <[email protected]>
Signed-off-by: psakiev <[email protected]>
Move main docs to packaging and add a qualifying not in the git versions section Signed-off-by: psakiev <[email protected]>
Signed-off-by: psakiev <[email protected]>
Signed-off-by: psakiev <[email protected]>
becker33
requested changes
Aug 27, 2025
psakievich
commented
Aug 27, 2025
Contributor
Author
psakievich
left a comment
psakievich
left a comment
There was a problem hiding this comment.
Leaving a comment since my phone is making all my comments be embedded in reviews.
Signed-off-by: psakiev <[email protected]>
Contributor
Author
|
@becker33 I just removed the word |
becker33
previously approved these changes
Aug 28, 2025
Member
|
Looks like the tests need to be updated for the changed method name, but otherwise LGTM |
Signed-off-by: psakiev <[email protected]>
becker33
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #51167 by moving the commit variant population before specs are finalized.