Skip to content

solver: catch invalid dependencies during concretization#51176

Merged
alalazo merged 2 commits intospack:developfrom
alalazo:bugfixes/solver-caret-in-literals
Aug 19, 2025
Merged

solver: catch invalid dependencies during concretization#51176
alalazo merged 2 commits intospack:developfrom
alalazo:bugfixes/solver-caret-in-literals

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Aug 19, 2025

fixes #51146
fixes #51067

Improve error handling to detect and report cases where a caret in the input spec incorrectly references transitive build dependencies.

Example

$ spack spec paraview+qt+python+hdf5+raytracing %gcc ^[email protected]
==> Error: failed to concretize `paraview+hdf5+python+qt+raytracing %gcc ^[email protected]` for the following reasons:
     1. ispc is not a direct 'build' dependency, or transitive 'link' or 'run' dependency of any root

@alalazo alalazo added bugfix Something wasn't working, here's a fix v1.0.2 PRs / Bug fixes to backport for v1.0.2 labels Aug 19, 2025
fixes spack#51146
fixes spack#51067

Improve error handling to detect and report cases where
a caret in the input spec incorrectly references
transitive build dependencies.

Signed-off-by: Massimiliano Culpo <[email protected]>
@alalazo alalazo force-pushed the bugfixes/solver-caret-in-literals branch from 3c441e9 to f092298 Compare August 19, 2025 11:55
@haampie
Copy link
Copy Markdown
Member

haampie commented Aug 19, 2025

What about test types?

Signed-off-by: Massimiliano Culpo <[email protected]>
@alalazo alalazo merged commit b4b1c5f into spack:develop Aug 19, 2025
33 checks passed
@alalazo alalazo deleted the bugfixes/solver-caret-in-literals branch August 19, 2025 15:26
@alalazo alalazo mentioned this pull request Aug 22, 2025
26 tasks
alalazo added a commit that referenced this pull request Aug 22, 2025
fixes #51146
fixes #51067

Improve error handling to detect and report cases where
a caret in the input spec incorrectly references
transitive build dependencies.

Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo added a commit that referenced this pull request Aug 22, 2025
fixes #51146
fixes #51067

Improve error handling to detect and report cases where
a caret in the input spec incorrectly references
transitive build dependencies.

Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo added a commit that referenced this pull request Aug 22, 2025
fixes #51146
fixes #51067

Improve error handling to detect and report cases where
a caret in the input spec incorrectly references
transitive build dependencies.

Signed-off-by: Massimiliano Culpo <[email protected]>
haampie pushed a commit that referenced this pull request Sep 12, 2025
fixes #51146
fixes #51067

Improve error handling to detect and report cases where
a caret in the input spec incorrectly references
transitive build dependencies.

Signed-off-by: Massimiliano Culpo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix v1.0.2 PRs / Bug fixes to backport for v1.0.2

Projects

None yet

2 participants