solver: relax rule to construct build unification sets#51152
Merged
alalazo merged 2 commits intospack:developfrom Aug 25, 2025
Merged
solver: relax rule to construct build unification sets#51152alalazo merged 2 commits intospack:developfrom
alalazo merged 2 commits intospack:developfrom
Conversation
Don't branch on "build" dependencies, but on "build"-only
dependencies. This effectively reduces the number of nodes
in the "generic_build" unification set, removing the ones
that could be ("build", "run") or ("build", "link").
Signed-off-by: Massimiliano Culpo <[email protected]>
Member
Author
Member
concretizer:
duplicates:
max_dupes:
py-jupyterlab: 2
py-jupyter-packaging: 2
py-jupyterlab-server: 2
py-jupyter-server: 2^ Should we make this the default? Could be a separate PR if you want. |
Signed-off-by: Massimiliano Culpo <[email protected]>
Member
Author
|
Yeah, I need to think if this is the right choice, or if I just need to add more build tools 😞 We should make everything its own PR and time concretization, cause adding more nodes will probably slow it down. |
alalazo
added
bugfix
Member
|
haampie
approved these changes
Aug 25, 2025
Member
concretizer:
duplicates:
max_dupes:
py-jupyterlab: 2
py-jupyter-packaging: 2
py-jupyterlab-server: 2
py-jupyter-server: 2^ @alalazo do you want to open a PR to add this too? |
Member
Author
|
@adamjstewart Yeah, I'll do that and check how much it affects the concretizer. Maybe we should also start benchmarking concretization of ml specs. |
Member
|
This isn't used by any ML packages, only Jupyter packages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #51134
Don't branch on "build" dependencies, but on "build"-only dependencies. This effectively reduces the number of nodes in the "generic_build" unification set, removing the ones that could be ("build", "run") or ("build", "link").
With this PR, spack/spack-packages#1078, and the following configuration:
I can concretize
py-geemapcorrectly.I still need to figure out a good unit test, and whether this relaxation may cause issues in other edge cases.