repo: don't overwrite branch when initially cloning repo#51105
Merged
becker33 merged 2 commits intospack:developfrom Aug 4, 2025
Merged
repo: don't overwrite branch when initially cloning repo#51105becker33 merged 2 commits intospack:developfrom
becker33 merged 2 commits intospack:developfrom
Conversation
Signed-off-by: Alec Scott <[email protected]>
becker33
previously approved these changes
Aug 4, 2025
Member
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
lib/spack/spack/repo.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted lib/spack/spack/repo.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 614 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
Signed-off-by: Alec Scott <[email protected]>
alecbcs
force-pushed
the
fix/repo-init-branch
branch
from
594901d to
19c26e6
Compare
becker33
approved these changes
Aug 4, 2025
haampie
pushed a commit
that referenced
this pull request
Aug 11, 2025
Signed-off-by: Alec Scott <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alecbcs
added a commit
that referenced
this pull request
Aug 12, 2025
Signed-off-by: Alec Scott <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
3 tasks
alstar555
pushed a commit
to alstar555/spack
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Alec Scott <[email protected]> Signed-off-by: Angelica Loshak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@becker33 identified a bug where v1.0 instances of Spack were not correctly defaulting to the stable release of the packages repository. That happened due to how we tried to find the default branch for a remote repository and were accidentally replacing any supplied branch with that of the dynamically determined branch.
This PR gates that dynamic logic behind a conditional statement if a branch, tag, or commit are NOT specified.