Validate results for terminal size and fallback to env vars on bad size#51090
Merged
becker33 merged 1 commit intospack:developfrom Aug 6, 2025
Merged
Conversation
Signed-off-by: Alec Scott <[email protected]>
alecbcs
added
v1.0.1
becker33
approved these changes
Aug 6, 2025
haampie
pushed a commit
that referenced
this pull request
Aug 11, 2025
…ze (#51090) Signed-off-by: Alec Scott <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alecbcs
added a commit
that referenced
this pull request
Aug 12, 2025
…ze (#51090) Signed-off-by: Alec Scott <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alstar555
pushed a commit
to alstar555/spack
that referenced
this pull request
Aug 27, 2025
…ze (spack#51090) Signed-off-by: Alec Scott <[email protected]> Signed-off-by: Angelica Loshak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions appears to return -2 when querying for the terminal width which causes us to fail when generating tutorial outputs. This patch adds a validation step so that we fallback to the environment variables in the case we get a negative value from the file descriptors.