spack edit -b: support specifying build_system repos/namespace#51084
Merged
spack edit -b: support specifying build_system repos/namespace#51084
Conversation
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying repository/namespace when editing build systems with spack edit -b, allowing users to access build systems from repos other than the highest priority one.
- Removes the
ComputeBuildSystemPathActionclass and replaces it with simpler logic - Updates argument parsing to support repo/namespace specification for build systems
- Adds a
repo_from_argsfunction to determine the appropriate repository based on command arguments
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/spack/spack/cmd/edit.py | Main implementation adding repo/namespace support for build systems |
| lib/spack/spack/repo.py | Adds build_systems_path attribute to Repo class |
| lib/spack/spack/test/cmd/edit.py | Regression test for the new functionality |
| share/spack/spack-completion.fish | Updates help text to reflect new fullname support |
haampie
reviewed
Aug 6, 2025
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
alecbcs
added
v1.0.2
haampie
approved these changes
Aug 18, 2025
Member
I'm not really sure this PR is much of an improvement to
at this point I would have just run (also, you just somehow have to know what the name of a build system is, in this case |
alalazo
pushed a commit
that referenced
this pull request
Aug 22, 2025
Signed-off-by: Gregory Becker <[email protected]>
alalazo
pushed a commit
that referenced
this pull request
Aug 22, 2025
Signed-off-by: Gregory Becker <[email protected]>
alalazo
pushed a commit
that referenced
this pull request
Aug 22, 2025
Signed-off-by: Gregory Becker <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
pushed a commit
that referenced
this pull request
Sep 12, 2025
Signed-off-by: Gregory Becker <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to use
spack edit -bto edit a build system that is not in the highest priority repo. This is a problem for users with multiple repos, as they often use the build systems frombuiltin.This PR supports specifying the repo or namespace for a build system passed to
spack edit -b.Things it does not support:
spack edit -bcommandThose are not supported because they would require more substantial additions to the
spack.repo.RepoPathobject, and it's dubious whether the usefulness for this command is worth the additional maintenance burden in the codeIncludes regression test.