Skip to content

docs: a few more updates for variants#51083

Merged
haampie merged 12 commits intodevelopfrom
hs/docs/do-not-use-tabs
Jul 31, 2025
Merged

docs: a few more updates for variants#51083
haampie merged 12 commits intodevelopfrom
hs/docs/do-not-use-tabs

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Jul 31, 2025

  • The use of tabs in the Spec Syntax section makes it impossible to Ctrl+F because it's hidden, and prevents linking to these sections as they don't appear in the outline.
  • Fix an issue where the packaging guide introduced single-valued variants incorrectly as multi-valued variants.
  • Improve the section about conditional variants
  • Document self.spec.variants[...].value for use in build configuration.

@haampie haampie force-pushed the hs/docs/do-not-use-tabs branch from cef2e4d to 878e5ff Compare July 31, 2025 10:59
@haampie haampie added the v1.0.1 PRs to backport for v1.0.1 label Jul 31, 2025
@haampie haampie added this to the v1.1.0 milestone Jul 31, 2025
@haampie haampie force-pushed the hs/docs/do-not-use-tabs branch 5 times, most recently from d1b66f3 to 56573dd Compare July 31, 2025 12:27
@haampie haampie changed the title docs: do not use tabs in spec_syntax.rst docs: a few more updates for variants Jul 31, 2025
becker33
becker33 previously approved these changes Jul 31, 2025
@becker33 becker33 enabled auto-merge (squash) July 31, 2025 13:40
@haampie haampie force-pushed the hs/docs/do-not-use-tabs branch from b5aea91 to 6cbe941 Compare July 31, 2025 13:45
@haampie haampie disabled auto-merge July 31, 2025 13:51
@haampie haampie merged commit 663b5f8 into develop Jul 31, 2025
29 checks passed
@haampie haampie deleted the hs/docs/do-not-use-tabs branch July 31, 2025 13:51
haampie added a commit that referenced this pull request Jul 31, 2025
* The use of tabs in the Spec Syntax section makes it impossible to `Ctrl+F` because it's hidden, and prevents linking to these sections as they don't appear in the outline.
* Fix an issue where the packaging guide introduced single-valued variants incorrectly as multi-valued variants.
* Improve the section about conditional variants
* Document `self.spec.variants[...].value` for use in build configuration.

Signed-off-by: Harmen Stoppels <[email protected]>
@haampie haampie mentioned this pull request Jul 31, 2025
29 tasks
alecbcs pushed a commit that referenced this pull request Aug 12, 2025
* The use of tabs in the Spec Syntax section makes it impossible to `Ctrl+F` because it's hidden, and prevents linking to these sections as they don't appear in the outline.
* Fix an issue where the packaging guide introduced single-valued variants incorrectly as multi-valued variants.
* Improve the section about conditional variants
* Document `self.spec.variants[...].value` for use in build configuration.

Signed-off-by: Harmen Stoppels <[email protected]>
alstar555 pushed a commit to alstar555/spack that referenced this pull request Aug 27, 2025
* The use of tabs in the Spec Syntax section makes it impossible to `Ctrl+F` because it's hidden, and prevents linking to these sections as they don't appear in the outline.
* Fix an issue where the packaging guide introduced single-valued variants incorrectly as multi-valued variants.
* Improve the section about conditional variants
* Document `self.spec.variants[...].value` for use in build configuration.

Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1.0.1 PRs to backport for v1.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants