git_fetch: make sparse path mirror projections unique#51080
Merged
psakievich merged 7 commits intospack:developfrom Aug 4, 2025
Merged
git_fetch: make sparse path mirror projections unique#51080psakievich merged 7 commits intospack:developfrom
psakievich merged 7 commits intospack:developfrom
Conversation
For two packages sharing the same commit plus sparse paths the mirror layout is overriding one another See spack#50699 Signed-off-by: psakiev <[email protected]>
Apply changes suggested by @tjfulle in spack#50699 Signed-off-by: psakiev <[email protected]>
4 tasks
psakievich
changed the title
haampie
reviewed
Jul 31, 2025
haampie
reviewed
Jul 31, 2025
haampie
requested changes
Jul 31, 2025
Member
haampie
left a comment
haampie
left a comment
There was a problem hiding this comment.
I don't think the test is accurate.
Signed-off-by: psakiev <[email protected]>
Signed-off-by: psakiev <[email protected]>
haampie
reviewed
Jul 31, 2025
Signed-off-by: psakiev <[email protected]>
Signed-off-by: psakiev <[email protected]>
becker33
previously approved these changes
Jul 31, 2025
haampie
reviewed
Jul 31, 2025
Signed-off-by: psakiev <[email protected]>
becker33
approved these changes
Aug 4, 2025
Contributor
Author
|
I'm setting to automerge. This is breaking us from updating spack to 1.0. I believe all review requests have been resolved. |
Contributor
Author
|
Closes #50699 |
haampie
approved these changes
Aug 4, 2025
haampie
pushed a commit
that referenced
this pull request
Aug 11, 2025
* git_fetch: sparse path stages aren't unique For two packages sharing the same commit plus sparse paths the mirror layout is overriding one another See #50699 Signed-off-by: psakiev <[email protected]> * Apply changes from @tjfulle Apply changes suggested by @tjfulle in #50699 Signed-off-by: psakiev <[email protected]> * Remove superfluous test lines Signed-off-by: psakiev <[email protected]> * Pathlib for git projection Signed-off-by: psakiev <[email protected]> * Update test comment Signed-off-by: psakiev <[email protected]> * Use hash for sparse-path list Signed-off-by: psakiev <[email protected]> * Use reproducible hash algorithm Signed-off-by: psakiev <[email protected]> --------- Signed-off-by: psakiev <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alecbcs
pushed a commit
that referenced
this pull request
Aug 12, 2025
* git_fetch: sparse path stages aren't unique For two packages sharing the same commit plus sparse paths the mirror layout is overriding one another See #50699 Signed-off-by: psakiev <[email protected]> * Apply changes from @tjfulle Apply changes suggested by @tjfulle in #50699 Signed-off-by: psakiev <[email protected]> * Remove superfluous test lines Signed-off-by: psakiev <[email protected]> * Pathlib for git projection Signed-off-by: psakiev <[email protected]> * Update test comment Signed-off-by: psakiev <[email protected]> * Use hash for sparse-path list Signed-off-by: psakiev <[email protected]> * Use reproducible hash algorithm Signed-off-by: psakiev <[email protected]> --------- Signed-off-by: psakiev <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alstar555
pushed a commit
to alstar555/spack
that referenced
this pull request
Aug 27, 2025
* git_fetch: sparse path stages aren't unique For two packages sharing the same commit plus sparse paths the mirror layout is overriding one another See spack#50699 Signed-off-by: psakiev <[email protected]> * Apply changes from @tjfulle Apply changes suggested by @tjfulle in spack#50699 Signed-off-by: psakiev <[email protected]> * Remove superfluous test lines Signed-off-by: psakiev <[email protected]> * Pathlib for git projection Signed-off-by: psakiev <[email protected]> * Update test comment Signed-off-by: psakiev <[email protected]> * Use hash for sparse-path list Signed-off-by: psakiev <[email protected]> * Use reproducible hash algorithm Signed-off-by: psakiev <[email protected]> --------- Signed-off-by: psakiev <[email protected]> Signed-off-by: Angelica Loshak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For two packages sharing the same commit plus sparse paths the mirror layout is overriding one another. This PR is to resolve the issue. This should be back-ported to 1.0.1 since it affects the ability to generate a mirror correctly.
See #50699