docs: use xrefs to spack.package where possible & improve multi-valued variants section#51079
Merged
docs: use xrefs to spack.package where possible & improve multi-valued variants section#51079
spack.package where possible & improve multi-valued variants section#51079Conversation
haampie
force-pushed
the
hs/docs/fix-references
branch
from
58b8b3a to
72c9e5b
Compare
… variants Signed-off-by: Harmen Stoppels <[email protected]>
haampie
force-pushed
the
hs/docs/fix-references
branch
from
72c9e5b to
a4b0149
Compare
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
haampie
force-pushed
the
hs/docs/fix-references
branch
from
09bf5c5 to
8de3243
Compare
haampie
changed the title
spack.package where possible & improve multi-valued variants section
tgamblin
approved these changes
Jul 31, 2025
haampie
added a commit
that referenced
this pull request
Jul 31, 2025
…ued variants section (#51079) The packaging guide should always refer to `spack.package` when possible, to prevent people from importing private Spack API. The only thing that is indirectly exposed from internals is the class `DisjointSetsOfValues`. I don't think that's terrible, just that we have to keep in mind that this is effectively also public API... * docs: fix reference spack.directives -> spack.package, and rewords mv variants * Ensure all xrefs point to spack.package in packaging_*.rst --------- Signed-off-by: Harmen Stoppels <[email protected]>
alecbcs
pushed a commit
that referenced
this pull request
Aug 12, 2025
…ued variants section (#51079) The packaging guide should always refer to `spack.package` when possible, to prevent people from importing private Spack API. The only thing that is indirectly exposed from internals is the class `DisjointSetsOfValues`. I don't think that's terrible, just that we have to keep in mind that this is effectively also public API... * docs: fix reference spack.directives -> spack.package, and rewords mv variants * Ensure all xrefs point to spack.package in packaging_*.rst --------- Signed-off-by: Harmen Stoppels <[email protected]>
alstar555
pushed a commit
to alstar555/spack
that referenced
this pull request
Aug 27, 2025
…ued variants section (spack#51079) The packaging guide should always refer to `spack.package` when possible, to prevent people from importing private Spack API. The only thing that is indirectly exposed from internals is the class `DisjointSetsOfValues`. I don't think that's terrible, just that we have to keep in mind that this is effectively also public API... * docs: fix reference spack.directives -> spack.package, and rewords mv variants * Ensure all xrefs point to spack.package in packaging_*.rst --------- Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Angelica Loshak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packaging guide should always refer to
spack.packagewhen possible, to prevent people from importing private Spack API.The only thing that is indirectly exposed from internals is the class
DisjointSetsOfValues. I don't think that's terrible, just that we have to keep in mind that this is effectively also public API...