spack diff: show runtime differences#51076
Merged
Conversation
Member
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
lib/spack/spack/cmd/diff.py
lib/spack/spack/solver/asp.py
lib/spack/spack/test/cmd/diff.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted lib/spack/spack/cmd/diff.py
All done! ✨ 🍰 ✨
1 file reformatted, 2 files left unchanged.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 614 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
becker33
force-pushed
the
bugfix/spack-diff-show-runtimes
branch
from
3eed1e0 to
cf2a3b0
Compare
Signed-off-by: Gregory Becker <[email protected]>
tgamblin
approved these changes
Jul 31, 2025
haampie
pushed a commit
that referenced
this pull request
Jul 31, 2025
Currently, differences in `gcc-runtime` or `glibc` packages are hidden by `spack diff`. This is an unintended artifact of how they are specially handled in the solver. This PR adds an option to `SpecSolverSetup.spec_clauses` to include runtime specs that are not unified in the spec. The `spack diff` command calls `spec_clauses` with the new option, to ensure those differences are represented in the `spack diff` output. Includes regression test. --------- Signed-off-by: Gregory Becker <[email protected]> Co-authored-by: becker33 <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alecbcs
pushed a commit
that referenced
this pull request
Aug 12, 2025
Currently, differences in `gcc-runtime` or `glibc` packages are hidden by `spack diff`. This is an unintended artifact of how they are specially handled in the solver. This PR adds an option to `SpecSolverSetup.spec_clauses` to include runtime specs that are not unified in the spec. The `spack diff` command calls `spec_clauses` with the new option, to ensure those differences are represented in the `spack diff` output. Includes regression test. --------- Signed-off-by: Gregory Becker <[email protected]> Co-authored-by: becker33 <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alstar555
pushed a commit
to alstar555/spack
that referenced
this pull request
Aug 27, 2025
Currently, differences in `gcc-runtime` or `glibc` packages are hidden by `spack diff`. This is an unintended artifact of how they are specially handled in the solver. This PR adds an option to `SpecSolverSetup.spec_clauses` to include runtime specs that are not unified in the spec. The `spack diff` command calls `spec_clauses` with the new option, to ensure those differences are represented in the `spack diff` output. Includes regression test. --------- Signed-off-by: Gregory Becker <[email protected]> Co-authored-by: becker33 <[email protected]> Signed-off-by: Angelica Loshak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, differences in
gcc-runtimeorglibcpackages are hidden byspack diff. This is an unintended artifact of how they are specially handled in the solver.This PR adds an option to
SpecSolverSetup.spec_clausesto include runtime specs that are not unified in the spec. Thespack diffcommand callsspec_clauseswith the new option, to ensure those differences are represented in thespack diffoutput.Includes regression test.