solver: fix issue when llvm is not a pure build dependency#51074
Merged
haampie merged 1 commit intospack:developfrom Jul 30, 2025
Merged
solver: fix issue when llvm is not a pure build dependency#51074haampie merged 1 commit intospack:developfrom
llvm is not a pure build dependency#51074haampie merged 1 commit intospack:developfrom
Conversation
fixes spack#51058 spack#50565 regressed this case by missing the fact that a "provider_set" on the direct dependency must be honored even if the direct dependency turns out to be needed at runtime Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
added
concretization
bugfix
This was referenced Jul 30, 2025
Member
Author
|
Benchmarked against
radiuss.develop.csv 
I'm always 🤔 how some specs are unstable for small changes to the ASP, but overall this is fine. |
haampie
approved these changes
Jul 30, 2025
haampie
pushed a commit
that referenced
this pull request
Jul 30, 2025
e4d4f6c regressed this case by missing the fact that a "provider_set" on the direct dependency must be honored even if the direct dependency turns out to be needed at runtime. Signed-off-by: Massimiliano Culpo <[email protected]>
alecbcs
pushed a commit
that referenced
this pull request
Aug 12, 2025
e4d4f6c regressed this case by missing the fact that a "provider_set" on the direct dependency must be honored even if the direct dependency turns out to be needed at runtime. Signed-off-by: Massimiliano Culpo <[email protected]>
alstar555
pushed a commit
to alstar555/spack
that referenced
this pull request
Aug 27, 2025
…#51074) e4d4f6c regressed this case by missing the fact that a "provider_set" on the direct dependency must be honored even if the direct dependency turns out to be needed at runtime. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Angelica Loshak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #51058
fixes #51062
#50565 regressed this case by missing the fact that a "provider_set" on the direct dependency must be honored even if the direct dependency turns out to be needed at runtime.