Skip to content

solver: fix issues with externals specifying a compiler#51064

Merged
haampie merged 1 commit intospack:developfrom
alalazo:bugfix/externals-with-compiler
Jul 30, 2025
Merged

solver: fix issues with externals specifying a compiler#51064
haampie merged 1 commit intospack:developfrom
alalazo:bugfix/externals-with-compiler

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Jul 29, 2025

fixes #51001

Modifications:

  1. If the external is the root, with a compiler specified, ensure we pick the correct external
  2. Allow at most one external to be selected for a node

1. If the external is the root, with a compiler specified,
   ensure we pick the correct external
2. Allow at most one external to be selected for a node

Signed-off-by: Massimiliano Culpo <[email protected]>
@alalazo alalazo added bugfix Something wasn't working, here's a fix v1.0.1 PRs to backport for v1.0.1 labels Jul 29, 2025
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Jul 29, 2025

Tested against:

radiuss.pr.csv
radiuss.develop.csv

radiuss

@haampie haampie merged commit f37d494 into spack:develop Jul 30, 2025
32 checks passed
haampie pushed a commit that referenced this pull request Jul 30, 2025
1. If the external is the root, with a compiler specified, ensure we pick the correct external
2. Allow at most one external to be selected for a node

Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
@becker33 becker33 mentioned this pull request Jul 30, 2025
29 tasks
@alalazo alalazo deleted the bugfix/externals-with-compiler branch July 30, 2025 08:48
alecbcs pushed a commit that referenced this pull request Aug 12, 2025
1. If the external is the root, with a compiler specified, ensure we pick the correct external
2. Allow at most one external to be selected for a node

Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
alstar555 pushed a commit to alstar555/spack that referenced this pull request Aug 27, 2025
1. If the external is the root, with a compiler specified, ensure we pick the correct external
2. Allow at most one external to be selected for a node

Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix v1.0.1 PRs to backport for v1.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External packages with compiler-specific prefixes are broken?

2 participants