Fix non path-based package repositories in environments#51055
Merged
becker33 merged 3 commits intospack:developfrom Jul 31, 2025
Merged
Fix non path-based package repositories in environments#51055becker33 merged 3 commits intospack:developfrom
becker33 merged 3 commits intospack:developfrom
Conversation
Signed-off-by: Till Ehrengruber <[email protected]>
tehrengruber
force-pushed
the
fix_env_non_str_repo
branch
from
ff0dcce to
02218d0
Compare
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
lib/spack/spack/environment/environment.py
lib/spack/spack/test/cmd/env.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted lib/spack/spack/test/cmd/env.py
All done! ✨ 🍰 ✨
1 file reformatted, 1 file left unchanged.
black checks were clean
==> Running flake8 checks
lib/spack/spack/test/cmd/env.py:4601: [F541] f-string is missing placeholders
lib/spack/spack/test/cmd/env.py:4608: [F841] local variable 'test' is assigned to but never used
flake8 found errors
==> Running mypy checks
Success: no issues found in 614 source files
mypy checks were clean
I've updated the branch with style fixes. |
Signed-off-by: Till Ehrengruber <[email protected]>
tehrengruber
force-pushed
the
fix_env_non_str_repo
branch
from
f5f44c3 to
3dbb8aa
Compare
Signed-off-by: Till Ehrengruber <[email protected]>
alalazo
added
bugfix
becker33
approved these changes
Jul 31, 2025
haampie
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Fix #51054 Signed-off-by: Till Ehrengruber <[email protected]> * [@spackbot] updating style on behalf of tehrengruber Signed-off-by: Till Ehrengruber <[email protected]> --------- Signed-off-by: Till Ehrengruber <[email protected]> Co-authored-by: tehrengruber <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alecbcs
pushed a commit
that referenced
this pull request
Aug 12, 2025
* Fix #51054 Signed-off-by: Till Ehrengruber <[email protected]> * [@spackbot] updating style on behalf of tehrengruber Signed-off-by: Till Ehrengruber <[email protected]> --------- Signed-off-by: Till Ehrengruber <[email protected]> Co-authored-by: tehrengruber <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alstar555
pushed a commit
to alstar555/spack
that referenced
this pull request
Aug 27, 2025
* Fix spack#51054 Signed-off-by: Till Ehrengruber <[email protected]> * [@spackbot] updating style on behalf of tehrengruber Signed-off-by: Till Ehrengruber <[email protected]> --------- Signed-off-by: Till Ehrengruber <[email protected]> Co-authored-by: tehrengruber <[email protected]> Signed-off-by: Angelica Loshak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #51054
Fixes environments with non path-based repositories, e.g. something like
This is a bug introduced in #49084 and reported in #51054.