concretizer: fix direct dep w/ virtuals issue#51037
Merged
Conversation
haampie
force-pushed
the
hs/fix/direct-dependency-virtual
branch
from
c6a333e to
fb0b533
Compare
3 tasks
The following config
```yaml
packages:
all:
prefer:
- "%c=gcc"
- "%cxx=gcc"
- "%fortran=gcc"
```
exposes an issue in the solver where the "requirement weight" is
computed incorrectly.
It makes up the following statement:
```
attr("direct_dependency",node(0,"tmux"),node_requirement("virtual_on_incoming_edges","gcc","cxx"))
```
even though `tmux` does not depend on `cxx`.
This leads to `condition_holds` for `%cxx=gcc`, even though this virtual
does not end as a dependency of `tmux` in the solution.
Signed-off-by: Harmen Stoppels <[email protected]>
haampie
force-pushed
the
hs/fix/direct-dependency-virtual
branch
from
fb0b533 to
43c064d
Compare
becker33
approved these changes
Jul 24, 2025
haampie
added a commit
that referenced
this pull request
Jul 29, 2025
The following config
```yaml
packages:
all:
prefer:
- "%c=gcc"
- "%cxx=gcc"
- "%fortran=gcc"
```
exposes an issue in the solver where the "requirement weight" is
computed incorrectly.
It makes up the following statement:
```
attr("direct_dependency",node(0,"tmux"),node_requirement("virtual_on_incoming_edges","gcc","cxx"))
```
even though `tmux` does not depend on `cxx`.
This leads to `condition_holds` for `%cxx=gcc`, even though this virtual
does not end as a dependency of `tmux` in the solution.
Signed-off-by: Harmen Stoppels <[email protected]>
haampie
added a commit
that referenced
this pull request
Jul 29, 2025
The following config
```yaml
packages:
all:
prefer:
- "%c=gcc"
- "%cxx=gcc"
- "%fortran=gcc"
```
exposes an issue in the solver where the "requirement weight" is
computed incorrectly.
It makes up the following statement:
```
attr("direct_dependency",node(0,"tmux"),node_requirement("virtual_on_incoming_edges","gcc","cxx"))
```
even though `tmux` does not depend on `cxx`.
This leads to `condition_holds` for `%cxx=gcc`, even though this virtual
does not end as a dependency of `tmux` in the solution.
Signed-off-by: Harmen Stoppels <[email protected]>
alecbcs
pushed a commit
that referenced
this pull request
Aug 12, 2025
The following config
```yaml
packages:
all:
prefer:
- "%c=gcc"
- "%cxx=gcc"
- "%fortran=gcc"
```
exposes an issue in the solver where the "requirement weight" is
computed incorrectly.
It makes up the following statement:
```
attr("direct_dependency",node(0,"tmux"),node_requirement("virtual_on_incoming_edges","gcc","cxx"))
```
even though `tmux` does not depend on `cxx`.
This leads to `condition_holds` for `%cxx=gcc`, even though this virtual
does not end as a dependency of `tmux` in the solution.
Signed-off-by: Harmen Stoppels <[email protected]>
alstar555
pushed a commit
to alstar555/spack
that referenced
this pull request
Aug 27, 2025
The following config
```yaml
packages:
all:
prefer:
- "%c=gcc"
- "%cxx=gcc"
- "%fortran=gcc"
```
exposes an issue in the solver where the "requirement weight" is
computed incorrectly.
It makes up the following statement:
```
attr("direct_dependency",node(0,"tmux"),node_requirement("virtual_on_incoming_edges","gcc","cxx"))
```
even though `tmux` does not depend on `cxx`.
This leads to `condition_holds` for `%cxx=gcc`, even though this virtual
does not end as a dependency of `tmux` in the solution.
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51019.
The following (questionable but valid) config
exposes an issue in the solver where the "requirement weight" is
computed incorrectly.
It
hallucinatesmakes up the following statement:even though
tmuxdoes not depend oncxx.This leads to
condition_holdsfor%cxx=gcc, even though this virtualdoes not end up as a dependency of
tmuxin the solution.