Skip to content

Git provenance: exception for bad url#51022

Merged
psakievich merged 2 commits intodevelopfrom
b/provenance-fall-through
Jul 21, 2025
Merged

Git provenance: exception for bad url#51022
psakievich merged 2 commits intodevelopfrom
b/provenance-fall-through

Conversation

@psakievich
Copy link
Copy Markdown
Contributor

If a user provides a bad url concretization can fail due to a process exception for git ls-remote.
Add a try except guard for this case.

@psakievich psakievich added bugfix Something wasn't working, here's a fix snl-core-team Issue for SNL Spack developers labels Jul 19, 2025
@psakievich psakievich force-pushed the b/provenance-fall-through branch from 2fab737 to e8277ff Compare July 19, 2025 15:45
@psakievich psakievich requested a review from becker33 July 19, 2025 15:45
@biddisco
Copy link
Copy Markdown
Contributor

This fixes my git concretization problem as discussed on slack. Thanks

@psakievich psakievich merged commit 63ec8b1 into develop Jul 21, 2025
32 checks passed
@psakievich psakievich deleted the b/provenance-fall-through branch July 21, 2025 17:15
@haampie haampie added the v1.0.1 PRs to backport for v1.0.1 label Jul 24, 2025
haampie pushed a commit that referenced this pull request Jul 29, 2025
* Git provenance: exception for bad url

Signed-off-by: psakiev <[email protected]>

* Delete extra import

Signed-off-by: psakiev <[email protected]>

---------

Signed-off-by: psakiev <[email protected]>
@haampie haampie mentioned this pull request Jul 29, 2025
29 tasks
haampie pushed a commit that referenced this pull request Jul 29, 2025
* Git provenance: exception for bad url

Signed-off-by: psakiev <[email protected]>

* Delete extra import

Signed-off-by: psakiev <[email protected]>

---------

Signed-off-by: psakiev <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
alecbcs pushed a commit that referenced this pull request Aug 12, 2025
* Git provenance: exception for bad url

Signed-off-by: psakiev <[email protected]>

* Delete extra import

Signed-off-by: psakiev <[email protected]>

---------

Signed-off-by: psakiev <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
alstar555 pushed a commit to alstar555/spack that referenced this pull request Aug 27, 2025
* Git provenance: exception for bad url

Signed-off-by: psakiev <[email protected]>

* Delete extra import

Signed-off-by: psakiev <[email protected]>

---------

Signed-off-by: psakiev <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix snl-core-team Issue for SNL Spack developers v1.0.1 PRs to backport for v1.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants