Docs/Packaging: emphasize trusted downloads and provide PR review links#51014
Merged
haampie merged 13 commits intospack:developfrom Jul 30, 2025
Merged
Docs/Packaging: emphasize trusted downloads and provide PR review links#51014haampie merged 13 commits intospack:developfrom
haampie merged 13 commits intospack:developfrom
Conversation
tldahlgren
force-pushed
the
docs_packaging_trusted_downloads
branch
from
46b2be1 to
a71c3d0
Compare
Member
|
Can you format it as one line per sentence? That makes diffs smaller when adding/removing words. |
tldahlgren
force-pushed
the
docs_packaging_trusted_downloads
branch
3 times, most recently
from
eb2eeaa to
8c4b110
Compare
Contributor
Author
Done. |
haampie
reviewed
Jul 30, 2025
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
…ions Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Tamara Dahlgren <[email protected]>
tldahlgren
force-pushed
the
docs_packaging_trusted_downloads
branch
from
64ed5d5 to
b03a152
Compare
haampie
added a commit
that referenced
this pull request
Jul 30, 2025
…ks (#51014) Signed-off-by: Tamara Dahlgren <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alecbcs
pushed a commit
that referenced
this pull request
Aug 12, 2025
…ks (#51014) Signed-off-by: Tamara Dahlgren <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
alstar555
pushed a commit
to alstar555/spack
that referenced
this pull request
Aug 27, 2025
…ks (spack#51014) Signed-off-by: Tamara Dahlgren <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]> Signed-off-by: Angelica Loshak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is especially helpful to be able to provide links to relevant sections in the documentation when reviewing
spack/spack-packagesPRs. A sometimes controversial topic can be that of trusted downloads.So this PR primarily focuses on emphasizing whether different version directive options are trusted or not. It also provides links to the relevant sections and links to key sections. It also updates a few examples to either show the more trustworthy option or provide a note that mentions it.