allow managed environments to be organized into folders#50994
Merged
psakievich merged 4 commits intospack:developfrom Jul 29, 2025
Merged
allow managed environments to be organized into folders#50994psakievich merged 4 commits intospack:developfrom
psakievich merged 4 commits intospack:developfrom
Conversation
rbberger
force-pushed
the
feature/organize_envs
branch
from
37a40df to
ed89350
Compare
rbberger
force-pushed
the
feature/organize_envs
branch
from
ed89350 to
ed78fe4
Compare
Contributor
|
Looks great! Docs and test(s)? Seems pretty straightforward but definitely something we'd want to add to the documentation on environments. Assuming |
Member
Author
|
@psakievich yes, surprisingly it just worked. |
Signed-off-by: Richard Berger <[email protected]>
Signed-off-by: Richard Berger <[email protected]>
Signed-off-by: Richard Berger <[email protected]>
rbberger
force-pushed
the
feature/organize_envs
branch
from
9382083 to
393e82f
Compare
psakievich
requested changes
Jul 25, 2025
Contributor
psakievich
left a comment
psakievich
left a comment
There was a problem hiding this comment.
Making my request more formal.
Let's modify the docs to explain how environment projection with nested paths can be used and add in a unit-test that uses this feature to guard against breaking it with future changes.
Other than that LGTM. With 1.0 out now we should be able to merge this soon.
Signed-off-by: Richard Berger <[email protected]>
rbberger
force-pushed
the
feature/organize_envs
branch
from
1399c4a to
025066f
Compare
psakievich
approved these changes
Jul 29, 2025
alstar555
pushed a commit
to alstar555/spack
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Angelica Loshak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spack currently forces environments to have simple names. This forces a flat folder structure for all managed environments. This PR relaxes this restriction and allows a folder structure to help organize environments. This would allow pointing Spack to a known environment root for a project which may be organized this way.
Below is a typical env setup that could make use of this.
Background: I've been writing wrappers/tools to circumvent this limitation by making use of directory environments. This PR tries to bring the missing feature to Spack itself.
Marking this as draft for now until I see what else I break with this.