"spack mirror create -a" (mirror all) in parallel (continuation of #48411)#50901
Merged
scheibelp merged 74 commits intospack:developfrom Oct 2, 2025
Merged
"spack mirror create -a" (mirror all) in parallel (continuation of #48411)#50901scheibelp merged 74 commits intospack:developfrom
scheibelp merged 74 commits intospack:developfrom
Conversation
spackbot-app
bot
added
commands
core
alstar555
force-pushed
the
mirror-parallel-clean
branch
3 times, most recently
from
9b50502 to
e67d936
Compare
alstar555
force-pushed
the
mirror-parallel-clean
branch
2 times, most recently
from
0a8e17b to
bf914fb
Compare
scheibelp
requested changes
Jul 11, 2025
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
I have a few requests. Let me know if any seem off-base.
alstar555
force-pushed
the
mirror-parallel-clean
branch
3 times, most recently
from
91ef6f3 to
6ccd67d
Compare
scheibelp
requested changes
Jul 23, 2025
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
Thanks for the changes. After looking at the updates, I have a few more ideas for refactoring (a couple aspects of this are not purely refactoring though - e.g. I think there may be an issue with MirrorStats calculations, but I make a few suggestions for updating the tests which should catch that).
alstar555
force-pushed
the
mirror-parallel-clean
branch
2 times, most recently
from
5c5b034 to
ed1311a
Compare
scheibelp
requested changes
Aug 14, 2025
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
Thanks for the changes so far! I have more requests. Let me know if any seem off-base.
alstar555
force-pushed
the
mirror-parallel-clean
branch
2 times, most recently
from
f6b5e67 to
cf51b2f
Compare
alstar555
force-pushed
the
mirror-parallel-clean
branch
from
fab97c0 to
c4e2af6
Compare
scheibelp
requested changes
Sep 10, 2025
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
This looks nearly there. I also ran this myself on a small dag and the output looks good. I have a request for extending one of the tests, and a couple of other minor requests/questions.
alstar555
force-pushed
the
mirror-parallel-clean
branch
from
bfbdc0f to
e38c0a0
Compare
…functions Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
alstar555
force-pushed
the
mirror-parallel-clean
branch
from
866ab63 to
4885817
Compare
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
Signed-off-by: Angelica Loshak <[email protected]>
scheibelp
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the work started by @aquan9 in PR #48411 to improve the
spack mirror create -aperformance through parallelization. Uses the-j/--jobsflag to specify the number of workers used when creating a full mirror.I rebased the changes into the current develop branch and resolved merge conflicts.