Revert "Concretization Cache: Refactor + manifest testing"#50851
Merged
Revert "Concretization Cache: Refactor + manifest testing"#50851
Conversation
This reverts commit f17c7be.
alalazo
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #49589
There are, unfortunately, races in the cleanup code. We are seeing issues like this in CI:
and, more frequently:
The second issue appears to be that this sort:
is calling stat() redundantly on entries while not holding any read lock on them. I suspect the first is also a race on bucket creation and deletion.
We can work this out later and merge for 1.1.