Skip to content

Fix allowing conditional link dependencies on a compiler#50738

Merged
alecbcs merged 1 commit intospack:developfrom
alalazo:fixes/emacs-conditional-link-gcc
Jun 1, 2025
Merged

Fix allowing conditional link dependencies on a compiler#50738
alecbcs merged 1 commit intospack:developfrom
alalazo:fixes/emacs-conditional-link-gcc

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Jun 1, 2025

closes #50730

Also restores internal_error, which was unintentionally dropped in #50565

Also restores internal_error, which was unintentionally
dropped in spack#50565

Signed-off-by: Massimiliano Culpo <[email protected]>
@spackbot-app spackbot-app bot added core PR affects Spack core functionality dependencies new-variant new-version tests General test capability(ies) labels Jun 1, 2025
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Jun 1, 2025

@alecbcs

Copy link
Copy Markdown
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @alalazo!

@alecbcs alecbcs merged commit 674f8c0 into spack:develop Jun 1, 2025
36 checks passed
@alalazo alalazo deleted the fixes/emacs-conditional-link-gcc branch June 2, 2025 04:50
kshea21 pushed a commit to kshea21/spack that referenced this pull request Jun 18, 2025
Also restores internal_error, which was unintentionally
dropped in spack#50565

Signed-off-by: Massimiliano Culpo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality dependencies new-variant new-version tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants