namd: enabling support for intel-oneapi-compilers + CXXOPTS, COPTS fix#50656
Merged
tgamblin merged 8 commits intospack:developfrom Jun 3, 2025
Merged
namd: enabling support for intel-oneapi-compilers + CXXOPTS, COPTS fix#50656tgamblin merged 8 commits intospack:developfrom
tgamblin merged 8 commits intospack:developfrom
Conversation
Contributor
Author
|
@spackbot help |
|
You can interact with me in many ways!
I'll also help to label your pull request and assign reviewers! |
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/spack_repo/builtin/packages/namd/package.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/spack_repo/builtin/packages/namd/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 611 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
jcphill
reviewed
May 28, 2025
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/spack_repo/builtin/packages/namd/package.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/spack_repo/builtin/packages/namd/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
var/spack/repos/spack_repo/builtin/packages/namd/package.py:227: [F523] '...'.format(...) has unused arguments at position(s): 3
var/spack/repos/spack_repo/builtin/packages/namd/package.py:234: [F523] '...'.format(...) has unused arguments at position(s): 2
flake8 found errors
==> Running mypy checks
Success: no issues found in 611 source files
mypy checks were clean
I've updated the branch with style fixes. |
jcphill
suggested changes
Jun 2, 2025
jcphill
suggested changes
Jun 2, 2025
jcphill
approved these changes
Jun 2, 2025
tgamblin
approved these changes
Jun 2, 2025
Member
|
I enabled auto-merge -- if all the conversations are resolved, click resolve on them and the PR will squash and merge into Spack. |
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
Jun 18, 2025
spack#50656) intel-oneapi-compilers added to optim_opts Transfer cflags, cxxflags from Spack to COPTS, CXXOPTS. --------- Co-authored-by: teabagk7 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optim_optscflags,cxxflagsfrom Spack toCOPTS,CXXOPTS.