bugfix: add build system imports to new packages#50587
Merged
Conversation
|
Hi @tgamblin! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("tgamblin")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame cryoefThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
Since #50452, build systems are no longer in core and need their own imports. Specifically, in addition to: ```python from spack.package import * ``` you now also need, e.g.: ```python from spack_repo.builtin.build_systems.python import PythonPackage ``` Or similar for other build systems, or things will break. - [x] Fix `py-deprecat` package - [x] Fix `cryoef` package Signed-off-by: Todd Gamblin <[email protected]>
tgamblin
force-pushed
the
bugfix-add-build-system-imports
branch
from
7f72946 to
2853dd1
Compare
kwryankrattiger
approved these changes
May 21, 2025
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
May 21, 2025
Since spack#50452, build systems are no longer in core and need their own imports. Specifically, in addition to: ```python from spack.package import * ``` you now also need, e.g.: ```python from spack_repo.builtin.build_systems.python import PythonPackage ``` Or similar for other build systems, or things will break. - [x] Fix `py-deprecat` package - [x] Fix `cryoef` package Signed-off-by: Todd Gamblin <[email protected]>
abhishek1297
pushed a commit
to abhishek1297/spack-melissa
that referenced
this pull request
May 22, 2025
Since spack#50452, build systems are no longer in core and need their own imports. Specifically, in addition to: ```python from spack.package import * ``` you now also need, e.g.: ```python from spack_repo.builtin.build_systems.python import PythonPackage ``` Or similar for other build systems, or things will break. - [x] Fix `py-deprecat` package - [x] Fix `cryoef` package Signed-off-by: Todd Gamblin <[email protected]>
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
May 22, 2025
Since spack#50452, build systems are no longer in core and need their own imports. Specifically, in addition to: ```python from spack.package import * ``` you now also need, e.g.: ```python from spack_repo.builtin.build_systems.python import PythonPackage ``` Or similar for other build systems, or things will break. - [x] Fix `py-deprecat` package - [x] Fix `cryoef` package Signed-off-by: Todd Gamblin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #50452, build systems are no longer in core and need their own imports.
Specifically, in addition to:
you now also need, e.g.:
Or similar for other build systems, or things will break.
py-deprecatpackagecryoefpackage