Skip to content

trilinos: Bump Kokkos dependency#50498

Merged
tldahlgren merged 2 commits intospack:developfrom
sebrowne:update-trilinos-kokkos-dependency
Jun 3, 2025
Merged

trilinos: Bump Kokkos dependency#50498
tldahlgren merged 2 commits intospack:developfrom
sebrowne:update-trilinos-kokkos-dependency

Conversation

@sebrowne
Copy link
Copy Markdown
Contributor

Bump Kokkos/KokkosKernels dependency versions to correspond with trilinos/Trilinos#14038

Copy link
Copy Markdown

@ccober6 ccober6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sebrowne sebrowne force-pushed the update-trilinos-kokkos-dependency branch from 2ea7b91 to 46cc3f7 Compare May 15, 2025 20:56
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version sha256s confirmed.

@tldahlgren
Copy link
Copy Markdown
Contributor

Should we wait for a kokkos* maintainer to approve before merging?

@tldahlgren tldahlgren self-assigned this May 16, 2025
@sebrowne
Copy link
Copy Markdown
Contributor Author

@lucbv

@psakievich
Copy link
Copy Markdown
Contributor

Pipeline failure is due to a build failure for glew and appears to be unrelated

@sebrowne
Copy link
Copy Markdown
Contributor Author

sebrowne commented Jun 3, 2025

Ping @cedricchevalier19 @nmm0 @lucbv @srajama1 @brian-kelley to get eyes on the kokkos and kokkos-kernels changes

@cedricchevalier19
Copy link
Copy Markdown
Contributor

Kokkos* recipes have already been updated with #50271 .
Can you update/rebase this current branch?

@sebrowne sebrowne force-pushed the update-trilinos-kokkos-dependency branch from 46cc3f7 to 330ac12 Compare June 3, 2025 12:57
@sebrowne
Copy link
Copy Markdown
Contributor Author

sebrowne commented Jun 3, 2025

Kokkos* recipes have already been updated with #50271 . Can you update/rebase this current branch?

Thanks, didn't notice that. Now all this one does to those packages is more-closely pin the versions of kokkos and kokkos-kernels

Copy link
Copy Markdown
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tldahlgren tldahlgren enabled auto-merge (squash) June 3, 2025 17:49
@tldahlgren tldahlgren merged commit e3ab3e7 into spack:develop Jun 3, 2025
16 checks passed
kshea21 pushed a commit to kshea21/spack that referenced this pull request Jun 18, 2025
* Bump Trilinos/Kokkos dependency
  Signed-off-by: Samuel E. Browne <[email protected]>
* Pin Kokkos/KokkosKernels more specifically for releases
Signed-off-by: Samuel E. Browne <[email protected]>

---------

Signed-off-by: Samuel E. Browne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants