RepoSplit/tests: replace mock symlinks with builtin snapshots#50478
Closed
tldahlgren wants to merge 1 commit intospack:developfrom
Closed
RepoSplit/tests: replace mock symlinks with builtin snapshots#50478tldahlgren wants to merge 1 commit intospack:developfrom
tldahlgren wants to merge 1 commit intospack:developfrom
Conversation
spackbot-app
bot
added
dependencies
headers
libraries
new-version
virtual-dependencies
labels
15 tasks
Contributor
Author
|
Symlinks were recently removed so this PR is not longer relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the symlinks in the
builtin.mockrepository with snapshots of the files from thebuiltinrepository to decouple that dependency since thebuiltinpackage repository is being split off from this code base for v1.0.Note: This approach was brought up in the meeting on May 12th as a QAD option and, according to @becker33, has precedence.