install_test.py: append to install-time test log for multiple test phases by AlexanderRichert-NOAA · Pull Request #50477 · spack/spack

AlexanderRichert-NOAA · 2025-05-14T23:02:37Z

This PR is a proposed solution for #49200, where currently 'make installcheck' output overwrites 'make test'/'make check' output for autotools and makefile (and possibly other) packages. This PR modifies install_test.py to append to install-time-test-log.txt instead of overwriting when it's logged to by both check() and installcheck(). This in turn is achieved by allowing llnl/util/tty/log.py:log_output() to append to existing files.

I wouldn't mind if the check() output went to a different file from installcheck(), but I would ideally like some working solution sooner than later.

Fixes #49200

AlexanderRichert-NOAA · 2025-05-14T23:09:10Z

@spackbot fix style

spackbot-app · 2025-05-14T23:09:13Z

Let me see if I can fix that for you!

spackbot-app · 2025-05-14T23:10:30Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: import, isort, black, flake8, mypy
==> Modified files
  lib/spack/spack/install_test.py
  lib/spack/spack/test/install_test.py
  var/spack/test_repos/builtin.mock/packages/dummy-makefile-build-test-log/package.py
==> Running import checks
lib/spack/spack/test/install_test.py: missing import: spack.main (spack.main.SpackCommand)
  import found errors
==> Running isort checks
Fixing /tmp/tmpd20pbly9/spack/lib/spack/spack/test/install_test.py
  isort checks were clean
==> Running black checks
All done! ✨ 🍰 ✨
3 files left unchanged.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
Success: no issues found in 646 source files
  mypy checks were clean

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

AlexanderRichert-NOAA · 2025-05-16T18:00:35Z

@spackbot fix style

spackbot-app · 2025-05-16T18:00:39Z

Let me see if I can fix that for you!

spackbot-app · 2025-05-16T18:01:43Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: import, isort, black, flake8, mypy
==> Modified files
  lib/spack/llnl/util/tty/log.py
  lib/spack/spack/install_test.py
  lib/spack/spack/test/install_test.py
  var/spack/test_repos/builtin.mock/packages/dummy-makefile-build-test-log/package.py
==> Running import checks
  import checks were clean
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted lib/spack/llnl/util/tty/log.py
reformatted lib/spack/spack/install_test.py
All done! ✨ 🍰 ✨
2 files reformatted, 2 files left unchanged.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
Success: no issues found in 646 source files
  mypy checks were clean
==> spack style checks were clean

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

tldahlgren · 2025-08-20T19:00:49Z

Please resolve the conflicts then ping me.

Signed-off-by: Alex Richert <[email protected]>

AlexanderRichert-NOAA · 2025-08-21T18:16:12Z

Thanks @tldahlgren, please take another look

tldahlgren

The core changes work. I have requested paring down the unit test-related changes. (See comments.)

lib/spack/spack/test/install_test.py

Signed-off-by: Alex Richert <[email protected]>

…log_may25

tldahlgren

LGTM, thanks.

AlexanderRichert-NOAA · 2025-10-17T18:37:21Z

@tldahlgren I ran into the issues with windows that I did before, so I'm omitting the new cmd/install.py test functionality for win32.

tldahlgren

Please use pytest.mark.skipif() instead to skip the unit test on windows.

This will allow the unit-test to be flagged the output as a special case.

lib/spack/spack/test/cmd/install.py

tldahlgren

Thanks!

tldahlgren · 2025-10-17T19:21:47Z

There's information at https://github.com/spack/spack/pull/50477/checks?check_run_id=53044284480 for passing the DCO check.

AlexanderRichert-NOAA · 2025-10-17T19:28:35Z

Dang, I thought I had the auto-signoff enabled. Thanks

Signed-off-by: Alex Richert <[email protected]>

This reverts commit f14beed. Signed-off-by: Alex Richert <[email protected]>

…ases (spack#50477) * Append to install-time test log for multiple test phases Signed-off-by: Alex Richert <[email protected]> * log.py: fix tmp dir arg Signed-off-by: Alex Richert <[email protected]> * log.py: fix typo (:) Signed-off-by: Alex Richert <[email protected]> * use existing tests/pkg Signed-off-by: Alex Richert <[email protected]> * remove new test file/pkg Signed-off-by: Alex Richert <[email protected]> * test/cmd/install.py: skip log append check for win32 Signed-off-by: Alex Richert <[email protected]> * test/cmd/install.py: skip install 'tests' for win32 Signed-off-by: Alex Richert <[email protected]> * test/cmd/install.py: fix install test-skip logic (win32) Signed-off-by: Alex Richert <[email protected]> * test/cmd/install.py: skip test_package_output for windows Signed-off-by: Alex Richert <[email protected]> * Revert "test/cmd/install.py: skip test_package_output for windows" This reverts commit f14beed. Signed-off-by: Alex Richert <[email protected]> --------- Signed-off-by: Alex Richert <[email protected]>

install_test.py: append to install-time test log for multiple test phases (spack#50477)

spackbot-app bot added core PR affects Spack core functionality tests General test capability(ies) labels May 14, 2025

AlexanderRichert-NOAA force-pushed the append_install_test_log_may25 branch from 6dcb9db to 62c1042 Compare May 14, 2025 23:06

spackbot-app bot added the new-version label May 14, 2025

AlexanderRichert-NOAA marked this pull request as draft May 15, 2025 01:27

spackbot-app bot added the utilities label May 16, 2025

AlexanderRichert-NOAA marked this pull request as ready for review May 16, 2025 19:39

AlexanderRichert-NOAA requested review from tgamblin and tldahlgren June 2, 2025 16:00

AlexanderRichert-NOAA force-pushed the append_install_test_log_may25 branch from f7838bf to 12dad84 Compare August 21, 2025 02:31

Append to install-time test log for multiple test phases

a651554

Signed-off-by: Alex Richert <[email protected]>

AlexanderRichert-NOAA force-pushed the append_install_test_log_may25 branch from 12dad84 to a651554 Compare August 21, 2025 02:33

AlexanderRichert-NOAA added 2 commits August 21, 2025 09:16

log.py: fix tmp dir arg

dac56f6

Signed-off-by: Alex Richert <[email protected]>

log.py: fix typo (:)

bf40e15

Signed-off-by: Alex Richert <[email protected]>

tldahlgren requested changes Aug 22, 2025

View reviewed changes

lib/spack/spack/test/install_test.py Outdated Show resolved Hide resolved

tldahlgren self-assigned this Aug 22, 2025

AlexanderRichert-NOAA requested a review from tldahlgren October 15, 2025 23:15

AlexanderRichert-NOAA added 3 commits October 15, 2025 16:18

use existing tests/pkg

838e927

Signed-off-by: Alex Richert <[email protected]>

remove new test file/pkg

855378e

Signed-off-by: Alex Richert <[email protected]>

Merge remote-tracking branch 'llnl/develop' into append_install_test_…

e323835

…log_may25

AlexanderRichert-NOAA force-pushed the append_install_test_log_may25 branch from e4e2ae0 to e323835 Compare October 15, 2025 23:21

tldahlgren previously approved these changes Oct 16, 2025

View reviewed changes

AlexanderRichert-NOAA dismissed tldahlgren’s stale review via 7715734 October 17, 2025 17:04

AlexanderRichert-NOAA requested a review from tldahlgren October 17, 2025 18:37

tldahlgren requested changes Oct 17, 2025

View reviewed changes

lib/spack/spack/test/cmd/install.py Show resolved Hide resolved

lib/spack/spack/test/cmd/install.py Show resolved Hide resolved

AlexanderRichert-NOAA requested a review from tldahlgren October 17, 2025 19:10

tldahlgren approved these changes Oct 17, 2025

View reviewed changes

AlexanderRichert-NOAA added 5 commits October 17, 2025 12:29

test/cmd/install.py: skip log append check for win32

c2edb54

Signed-off-by: Alex Richert <[email protected]>

test/cmd/install.py: skip install 'tests' for win32

2b904fe

Signed-off-by: Alex Richert <[email protected]>

test/cmd/install.py: fix install test-skip logic (win32)

1050c82

Signed-off-by: Alex Richert <[email protected]>

test/cmd/install.py: skip test_package_output for windows

986c9d4

Signed-off-by: Alex Richert <[email protected]>

Revert "test/cmd/install.py: skip test_package_output for windows"

14165dc

This reverts commit f14beed. Signed-off-by: Alex Richert <[email protected]>

AlexanderRichert-NOAA force-pushed the append_install_test_log_may25 branch from 24a575b to 14165dc Compare October 17, 2025 19:29

AlexanderRichert-NOAA requested a review from tldahlgren October 17, 2025 21:07

tldahlgren approved these changes Oct 17, 2025

View reviewed changes

tldahlgren enabled auto-merge (squash) October 17, 2025 21:44

tldahlgren merged commit cdb2edf into spack:develop Oct 17, 2025
31 checks passed

climbfuji added a commit to JCSDA/spack that referenced this pull request Oct 24, 2025

Merge pull request #569 from AlexanderRichert-NOAA/test_log_fix_oct25

af7df61

install_test.py: append to install-time test log for multiple test phases (spack#50477)

Conversation

AlexanderRichert-NOAA commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexanderRichert-NOAA commented May 14, 2025

Uh oh!

spackbot-app bot commented May 14, 2025

Uh oh!

spackbot-app bot commented May 14, 2025

Uh oh!

AlexanderRichert-NOAA commented May 16, 2025

Uh oh!

spackbot-app bot commented May 16, 2025

Uh oh!

spackbot-app bot commented May 16, 2025

Uh oh!

tldahlgren commented Aug 20, 2025

Uh oh!

AlexanderRichert-NOAA commented Aug 21, 2025

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

AlexanderRichert-NOAA commented Oct 17, 2025

Uh oh!

tldahlgren left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

tldahlgren commented Oct 17, 2025

Uh oh!

AlexanderRichert-NOAA commented Oct 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AlexanderRichert-NOAA commented May 14, 2025 •

edited

Loading

tldahlgren left a comment •

edited

Loading