Don't discard deps based on conditional requirements#50194
Merged
haampie merged 1 commit intospack:developfrom Apr 25, 2025
Merged
Don't discard deps based on conditional requirements#50194haampie merged 1 commit intospack:developfrom
haampie merged 1 commit intospack:developfrom
Conversation
spackbot-app
bot
added
core
alalazo
force-pushed
the
bugfix/conditional-deps-input-analysis
branch
from
f48892d to
f7bacd8
Compare
fixes spack#50167 If a requirement cannot be met on the current platform, and is conditional, the valid search space is restricted to the complement of the conditional. Therefore, consider only unconditional requirement to discard possible dependencies. Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
force-pushed
the
bugfix/conditional-deps-input-analysis
branch
from
f7bacd8 to
59f3b85
Compare
haampie
approved these changes
Apr 25, 2025
danielsjensen1
added a commit
to danielsjensen1/spack
that referenced
this pull request
Apr 26, 2025
* develop: (752 commits) mesa: add v23.3.3 and use py-packaging while python>=3.12 (spack#49121) gcc: add v15.1.0 (spack#50212) draco: add v7.20.0 (spack#49996) sgpp: update dependencies and variants (spack#49384) input_analysis.py: fix conditional requirements (spack#50194) boost: add 1.88.0 (spack#50158) mapl: add v2.55.1 (spack#50201) mepo: add v2.3.2 (spack#50202) py-repligit: add v0.1.1 (spack#50204) [package updates] Bump version of cp2k and sirius (spack#50141) petsc4py: update ldshared.patch for v3.20.1, and skip for v3.23.1+ (spack#50170) namd: add v3.0.1 (spack#50192) geomodel: depend on c (spack#49781) CompilerAdaptor: add support for opt_flags/debug_flags (spack#50126) Add ls alias to spack {compiler, external} (spack#50189) covfie: depend on c (spack#50190) lua-sol2: add v3.5.0 (spack#49970) crtm-fix: fix directory logic (spack#50172) py-build: add v1.2.2 (spack#50148) py-pillow: fix build (spack#50177) ...
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
May 20, 2025
Fixes a logic bug where a -> b was assumed to imply not a -> not b in conditional requirements. Signed-off-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #50167
If a requirement cannot be met on the current platform, and is conditional, the valid search space is restricted to the complement of the conditional.
Therefore, consider only unconditional requirement to discard possible dependencies.