Skip to content

boost: add 1.88.0#50158

Merged
albestro merged 2 commits intospack:developfrom
msimberg:boost-1.88.0
Apr 25, 2025
Merged

boost: add 1.88.0#50158
albestro merged 2 commits intospack:developfrom
msimberg:boost-1.88.0

Conversation

@msimberg
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering, how the mqtt5 conflicts, but more in general a "sub-package" availability is modelled?

I see

# Add any extra requirements for specific
all_libs_opts = {"charconv": {"when": "@1.85.0:"}, "cobalt": {"when": "@1.84.0:"}}

and

# Container's Extended Allocators were not added until 1.56.0
conflicts("+container", when="@:1.55")

I would expect mqtt5 added somehow there too, no? am I missing something?

@msimberg
Copy link
Copy Markdown
Contributor Author

msimberg commented Apr 22, 2025

I'm just wondering, how the mqtt5 conflicts, but more in general a "sub-package" availability is modelled?

@hainest your input on this question would be valuable! I wasn't quite sure about the various (seemingly) ad-hoc conflicts and methods of enabling/disabling subpackages, so I only included the on that seems to be used the most, namely

        if not spec.satisfies("@1.88.0:"):
            with_libs.discard("mqtt5")

but I certainly wouldn't mind modeling that as a conflict instead. I just didn't want to start changing that for all the subpackages as that would be a significantly bigger change.

Unrelated, but do the build failures here look familiar to anyone: https://gitlab.spack.io/spack/spack/-/jobs/16344209#L423? A number of packages are failing with

error while loading shared libraries: libunwind.so.8: cannot open shared object file: No such file or directory

which sounds unrelated enough that it could be a failure that's already on develop, but I wouldn't be surprised if the new version of boost somehow triggers an error like that.

@hainest
Copy link
Copy Markdown
Contributor

hainest commented Apr 22, 2025

I'm just wondering, how the mqtt5 conflicts, but more in general a "sub-package" availability is modelled?

I see

# Add any extra requirements for specific
all_libs_opts = {"charconv": {"when": "@1.85.0:"}, "cobalt": {"when": "@1.84.0:"}}

and

# Container's Extended Allocators were not added until 1.56.0
conflicts("+container", when="@:1.55")

I would expect mqtt5 added somehow there too, no? am I missing something?

Conflicts are ad-hoc right now. If you have a specific conflict you need to resolve, please submit an issue here and I'll see what I can do. I really need to get #30627 done. It's in the last 5% which is the longest part.

@hainest
Copy link
Copy Markdown
Contributor

hainest commented Apr 22, 2025

I'm just wondering, how the mqtt5 conflicts, but more in general a "sub-package" availability is modelled?

@hainest your input on this question would be valuable! I wasn't quite sure about the various (seemingly) ad-hoc conflicts and methods of enabling/disabling subpackages, so I only included the on that seems to be used the most, namely

        if not spec.satisfies("@1.88.0:"):
            with_libs.discard("mqtt5")

That's good enough for now. I'm drastically changing variant modelling in #30627. I really need to finish that work. It's been lingering for too long.

but I certainly wouldn't mind modeling that as a conflict instead. I just didn't want to start changing that for all the subpackages as that would be a significantly bigger change.

Yes. It's a ridiculously bonkers big change that I've lost many hairs over.

Unrelated, but do the build failures here look familiar to anyone: https://gitlab.spack.io/spack/spack/-/jobs/16344209#L423? A number of packages are failing with

error while loading shared libraries: libunwind.so.8: cannot open shared object file: No such file or directory

which sounds unrelated enough that it could be a failure that's already on develop, but I wouldn't be surprised if the new version of boost somehow triggers an error like that.

That's running on a machine at UOregon. I have access to it, so I'll see if I can reproduce it.

@hainest
Copy link
Copy Markdown
Contributor

hainest commented Apr 22, 2025

@spackbot re-run failed pipelines

@msimberg
Copy link
Copy Markdown
Contributor Author

That's good enough for now. I'm drastically changing variant modelling in #30627. I really need to finish that work. It's been lingering for too long.

Ooh, awesome. I wasn't aware of that PR, and it's nice that you're working on it! In that case I'd definitely prefer to stick to the current suboptimal conflicts and let you handle it in #30627 😉

@hainest
Copy link
Copy Markdown
Contributor

hainest commented Apr 23, 2025

Unrelated, but do the build failures here look familiar to anyone: https://gitlab.spack.io/spack/spack/-/jobs/16344209#L423? A number of packages are failing with

error while loading shared libraries: libunwind.so.8: cannot open shared object file: No such file or directory

which sounds unrelated enough that it could be a failure that's already on develop, but I wouldn't be surprised if the new version of boost somehow triggers an error like that.

That's running on a machine at UOregon. I have access to it, so I'll see if I can reproduce it.

The CI jobs are using a compiler wrapper, so I can't really test this. I'll see if I can get the bot to re-run the jobs.

@hainest
Copy link
Copy Markdown
Contributor

hainest commented Apr 23, 2025

@spackbot re-run pipeline

@msimberg
Copy link
Copy Markdown
Contributor Author

I've rebased on latest develop. Apparently some/all the CI failures should be known failures that have been fixed (and the cray pipeline is known to be finicky...).

@msimberg msimberg requested a review from albestro April 25, 2025 06:50
@albestro albestro merged commit 8921612 into spack:develop Apr 25, 2025
16 checks passed
@msimberg msimberg deleted the boost-1.88.0 branch April 25, 2025 06:55
@msimberg msimberg mentioned this pull request Apr 25, 2025
4 tasks
danielsjensen1 added a commit to danielsjensen1/spack that referenced this pull request Apr 26, 2025
* develop: (752 commits)
  mesa: add v23.3.3 and use py-packaging while python>=3.12 (spack#49121)
  gcc: add v15.1.0 (spack#50212)
  draco: add v7.20.0 (spack#49996)
  sgpp: update dependencies and variants (spack#49384)
  input_analysis.py: fix conditional requirements (spack#50194)
  boost: add 1.88.0 (spack#50158)
  mapl: add v2.55.1 (spack#50201)
  mepo: add v2.3.2 (spack#50202)
  py-repligit: add v0.1.1 (spack#50204)
  [package updates] Bump version of cp2k and sirius (spack#50141)
  petsc4py: update ldshared.patch for v3.20.1, and skip for v3.23.1+ (spack#50170)
  namd: add v3.0.1 (spack#50192)
  geomodel: depend on c (spack#49781)
  CompilerAdaptor: add support for opt_flags/debug_flags (spack#50126)
  Add ls alias to spack {compiler, external} (spack#50189)
  covfie: depend on c (spack#50190)
  lua-sol2: add v3.5.0 (spack#49970)
  crtm-fix: fix directory logic (spack#50172)
  py-build: add v1.2.2 (spack#50148)
  py-pillow: fix build (spack#50177)
  ...
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request May 20, 2025
* boost: add 1.88.0

* pika: add conflict with boost 1.88.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants