Conversation
|
Hi @Chrismarsh! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("Chrismarsh")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame py-dask-exprThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
|
@bryanherman can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/py-dask-expr/package.py
var/spack/repos/builtin/packages/py-dask/package.py
var/spack/repos/builtin/packages/py-distributed/package.py
var/spack/repos/builtin/packages/py-h5py/package.py
var/spack/repos/builtin/packages/py-netcdf4/package.py
var/spack/repos/builtin/packages/py-pydap/package.py
var/spack/repos/builtin/packages/py-xarray/package.py
var/spack/repos/builtin/packages/py-zarr/package.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/py-distributed/package.py
reformatted var/spack/repos/builtin/packages/py-pydap/package.py
reformatted var/spack/repos/builtin/packages/py-h5py/package.py
reformatted var/spack/repos/builtin/packages/py-xarray/package.py
All done! ✨ 🍰 ✨
4 files reformatted, 4 files left unchanged.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 632 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
|
CI failure is unrelated to these changes |
Chrismarsh
force-pushed
the
package-fix/xarray-np2
branch
from
60b6d4d to
f6f8637
Compare
|
Does anyone know why I keep getting notified for this issue? I'm going to try to comment so I can subscribe and unsubscribe (because I don't see the option now). |
Chrismarsh
force-pushed
the
package-fix/xarray-np2
branch
from
f6f8637 to
aa9d537
Compare
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/py-dask-expr/package.py
var/spack/repos/builtin/packages/py-dask/package.py
var/spack/repos/builtin/packages/py-distributed/package.py
var/spack/repos/builtin/packages/py-h5netcdf/package.py
var/spack/repos/builtin/packages/py-h5py/package.py
var/spack/repos/builtin/packages/py-netcdf4/package.py
var/spack/repos/builtin/packages/py-pydap/package.py
var/spack/repos/builtin/packages/py-xarray/package.py
var/spack/repos/builtin/packages/py-zarr/package.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/py-netcdf4/package.py
All done! ✨ 🍰 ✨
1 file reformatted, 8 files left unchanged.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 632 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
Chrismarsh
force-pushed
the
package-fix/xarray-np2
branch
from
10a016d to
42fb521
Compare
haampie
force-pushed
the
package-fix/xarray-np2
branch
from
42fb521 to
465c8bd
Compare
…into package-fix/xarray-np2
…into package-fix/xarray-np2
…into package-fix/xarray-np2
|
@wdconinc sorry for the mess of commits, I messed up a rebase+merge. I think this addresses all of the comments. I rebased to get the changes from https://github.com/spack/spack/pull/50666/files and refined the numpy range |
var/spack/repos/spack_repo/builtin/packages/py_pydap/package.py
Outdated
Show resolved
Hide resolved
var/spack/repos/spack_repo/builtin/packages/py_xarray/package.py
Outdated
Show resolved
Hide resolved
var/spack/repos/spack_repo/builtin/packages/py_xarray/package.py
Outdated
Show resolved
Hide resolved
* Add changes required for xarray with all variants to concretize against numpy@2 * correctly enforce numpy < 2 for @:3.10 * add url_for_version for 3.2.2 * add new py-h5netcdf * ensure cython is guided to mpi compiler when ingesting a mpi h5 header --------- Co-authored-by: Chrismarsh <[email protected]>
6 participants
This fixes
py-xarrayand friends to concretize withnumpy@2:py-dask-exprandpy-distributedhad theirpy-versioneerversions bumped to0.28:which ensure they are compatible with the0.29required elsewhere in the dask ecosystem.py-daskhas the correct numpy bounds to ensure pre and post numpy2 compatible versionspy-h5pywas updated and numpy versions fixedpydaphad a new version added and fixed the URL for future versions.@3.2.2seems to occupy both the new and old url schemes, so I have updated the scheme without having to have a bespokeurl_for_versionhandlerpy-zarrwas updated for numpy2 compatible versionpy-zarralso had a mistake independs_on("py-packaging@:22.0", type=("build", "run"))which is now fixed. I verified all the previous versions back to 3.0 require@22:https://github.com/zarr-developers/zarr-python/blob/v3.0.0/pyproject.toml#L29