Conversation
clevelam
commented
Apr 9, 2025
- Update to the latest draco-7_20_0 release
- Cleanup GPU flags (distinguish between CUDA and ROCM)
- Specify openmp support
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I encountered an error attempting to format style. DetailsError: <class 'sh.ErrorReturnCode_123'>,
RAN: /tmp/tmp1zfbvobx/spack-develop/bin/spack --color never style --fix --root /tmp/tmp1zfbvobx/spack
STDOUT:
STDERR:
Stack trace:
File "/usr/local/lib/python3.9/site-packages/rq/worker.py", line 1633, in perform_job
return_value = job.perform()
File "/usr/local/lib/python3.9/site-packages/rq/job.py", line 1331, in perform
self._result = self._execute()
File "/usr/local/lib/python3.9/site-packages/rq/job.py", line 1368, in _execute
coro_result = loop.run_until_complete(result)
File "/usr/local/lib/python3.9/asyncio/base_events.py", line 647, in run_until_complete
return future.result()
File "/source/./spackbot/workers.py", line 344, in fix_style_task
res, err = helpers.run_command(
File "/source/./spackbot/helpers.py", line 164, in run_command
raise inst
File "/source/./spackbot/helpers.py", line 157, in run_command
control(*cmd, _out=res, _err=err, _ok_code=ok_codes)
File "/usr/local/lib/python3.9/site-packages/sh.py", line 1511, in __call__
rc = self.__class__.RunningCommandCls(cmd, call_args, stdin, stdout, stderr)
File "/usr/local/lib/python3.9/site-packages/sh.py", line 734, in __init__
self.wait()
File "/usr/local/lib/python3.9/site-packages/sh.py", line 796, in wait
self.handle_command_exit_code(exit_code)
File "/usr/local/lib/python3.9/site-packages/sh.py", line 823, in handle_command_exit_code
raise exc
|
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/draco/package.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/draco/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 632 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
KineticTheory
left a comment
There was a problem hiding this comment.
- New version, download, and hash are good.
- The subclassing from Cuda and Rocm is a nice update.
- Because compilers are now virtual dependencies, there will need to be an update after this PR that indicates a minimum compiler version. I think it will be something like
depends_on("[email protected]:", when="^[virtuals=cxx] gcc")but that syntax might not be correct.
|
@clevelam Can you change the title to @bernhardkaindl This is ready for your review. Please merge if it passes your review. Related to #47032 (draco v7.19.0). |
Done. |
bernhardkaindl
left a comment
There was a problem hiding this comment.
As @KineticTheory approved as maintainer, I add my approval. As he gave a detailed review comment it looks like his review is good.
* develop: (752 commits) mesa: add v23.3.3 and use py-packaging while python>=3.12 (spack#49121) gcc: add v15.1.0 (spack#50212) draco: add v7.20.0 (spack#49996) sgpp: update dependencies and variants (spack#49384) input_analysis.py: fix conditional requirements (spack#50194) boost: add 1.88.0 (spack#50158) mapl: add v2.55.1 (spack#50201) mepo: add v2.3.2 (spack#50202) py-repligit: add v0.1.1 (spack#50204) [package updates] Bump version of cp2k and sirius (spack#50141) petsc4py: update ldshared.patch for v3.20.1, and skip for v3.23.1+ (spack#50170) namd: add v3.0.1 (spack#50192) geomodel: depend on c (spack#49781) CompilerAdaptor: add support for opt_flags/debug_flags (spack#50126) Add ls alias to spack {compiler, external} (spack#50189) covfie: depend on c (spack#50190) lua-sol2: add v3.5.0 (spack#49970) crtm-fix: fix directory logic (spack#50172) py-build: add v1.2.2 (spack#50148) py-pillow: fix build (spack#50177) ...
Co-authored-by: Cleveland <[email protected]>