Skip to content

lua-sol2: add v3.5.0#49970

Merged
rbberger merged 3 commits intospack:developfrom
pbrady:update-sol2
Apr 23, 2025
Merged

lua-sol2: add v3.5.0#49970
rbberger merged 3 commits intospack:developfrom
pbrady:update-sol2

Conversation

@pbrady
Copy link
Copy Markdown
Contributor

@pbrady pbrady commented Apr 8, 2025

Note that 3.5 incorporates fixes to run with latest apple-clang: ThePhD/sol2#1684

@spackbot-app spackbot-app bot requested a review from rbberger April 8, 2025 18:52
RikkiButler20
RikkiButler20 previously approved these changes Apr 8, 2025
View reviewed changes
@RikkiButler20 RikkiButler20 self-assigned this Apr 8, 2025
@RikkiButler20
Copy link
Copy Markdown
Contributor

RikkiButler20 commented Apr 8, 2025

@rbberger Would you like to take a look at this before I merge?

rbberger
rbberger previously approved these changes Apr 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rbberger rbberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbberger rbberger changed the title sol2: update version sol2: add v3.5.0 Apr 8, 2025
@rbberger rbberger enabled auto-merge (squash) April 8, 2025 20:56
@RikkiButler20
Copy link
Copy Markdown
Contributor

RikkiButler20 commented Apr 9, 2025

@spackbot re-run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Apr 9, 2025

I've started that pipeline for you!

@rbberger
Copy link
Copy Markdown
Member

rbberger commented Apr 9, 2025 •
edited
Loading

looks like we need a version constraint for libpressio. Pinging @robertu94 who maintains it. Also, several versions of that are missing.

@robertu94
Copy link
Copy Markdown
Contributor

robertu94 commented Apr 9, 2025

@rbberger Thanks for the ping. I'm on deadline for SC25 right now; I'll make a note to test with [email protected] next week. LibPressio's unstable versions are updated on a separate spack repo, and then merged into mainline spack each November or so.

@alecbcs alecbcs changed the title sol2: add v3.5.0 lua-sol2: add v3.5.0 Apr 14, 2025
robertu94
robertu94 suggested changes Apr 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@robertu94 robertu94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[email protected] is not released yet with corresponding docs. I tried to do a quick fix, but it looks like the requirements for sol2's container type detection have changed, and my code doesn't conform to these requirements, and I don't have the expertise to quickly change my code to support this version without updated docs. The fix for now is set LibPressio's max sol2 version to 3.3 the currently released version.

@pbrady
Copy link
Copy Markdown
Contributor Author

pbrady commented Apr 22, 2025

Just to clarify: there's nothing incorrect with this PR but it interacts with the CI infrastructure in a bad way?

@rbberger rbberger disabled auto-merge April 22, 2025 20:47
@rbberger
Copy link
Copy Markdown
Member

rbberger commented Apr 22, 2025 •
edited
Loading

@pbrady Try updating https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/libpressio/package.py#L265 to

depends_on("lua-sol2@:3.3.0", when="+lua")

That should fix the CI.

@pbrady pbrady dismissed stale reviews from rbberger and RikkiButler20 via 61cc24c April 22, 2025 20:57
@pbrady
Copy link
Copy Markdown
Contributor Author

pbrady commented Apr 22, 2025

done!

@rbberger rbberger enabled auto-merge (squash) April 23, 2025 06:45
@rbberger rbberger merged commit 14513ba into spack:develop Apr 23, 2025
16 checks passed
@pbrady pbrady deleted the update-sol2 branch April 23, 2025 19:33
danielsjensen1 added a commit to danielsjensen1/spack that referenced this pull request Apr 26, 2025
@danielsjensen1
Merge branch 'develop' into override-package-directives
e24989b 
* develop: (752 commits)
  mesa: add v23.3.3 and use py-packaging while python>=3.12 (spack#49121)
  gcc: add v15.1.0 (spack#50212)
  draco: add v7.20.0 (spack#49996)
  sgpp: update dependencies and variants (spack#49384)
  input_analysis.py: fix conditional requirements (spack#50194)
  boost: add 1.88.0 (spack#50158)
  mapl: add v2.55.1 (spack#50201)
  mepo: add v2.3.2 (spack#50202)
  py-repligit: add v0.1.1 (spack#50204)
  [package updates] Bump version of cp2k and sirius (spack#50141)
  petsc4py: update ldshared.patch for v3.20.1, and skip for v3.23.1+ (spack#50170)
  namd: add v3.0.1 (spack#50192)
  geomodel: depend on c (spack#49781)
  CompilerAdaptor: add support for opt_flags/debug_flags (spack#50126)
  Add ls alias to spack {compiler, external} (spack#50189)
  covfie: depend on c (spack#50190)
  lua-sol2: add v3.5.0 (spack#49970)
  crtm-fix: fix directory logic (spack#50172)
  py-build: add v1.2.2 (spack#50148)
  py-pillow: fix build (spack#50177)
  ...
@greenc-FNAL greenc-FNAL mentioned this pull request May 15, 2025
Merged
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request May 20, 2025
@pbrady @rbberger @teaguesterling
lua-sol2: add v3.5.0 (spack#49970)
5d5801a 
* sol2: update version

* fix lua version in libpressio

---------

Co-authored-by: Richard Berger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbberger rbberger rbberger approved these changes

@RikkiButler20 RikkiButler20 RikkiButler20 left review comments

+1 more reviewer

@robertu94 robertu94 robertu94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RikkiButler20 RikkiButler20

Labels

dependencies new-version update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pbrady @RikkiButler20 @rbberger @robertu94