Skip to content

p4est: add v2.8.7#49859

Merged
tldahlgren merged 1 commit intospack:developfrom
climbfuji:feature/add_p4est_287_spack_dev
Apr 4, 2025
Merged

p4est: add v2.8.7#49859
tldahlgren merged 1 commit intospack:developfrom
climbfuji:feature/add_p4est_287_spack_dev

Conversation

@climbfuji
Copy link
Copy Markdown
Contributor

@climbfuji climbfuji commented Apr 3, 2025

Add latest version [email protected]. Built successfully on Alma Linux 9 with gcc@13, and verified that the pkg-config bug present in older versions of p4est is now fixed (see cburstedde/p4est#343):

$ ls -lart envs/p4est-test/install/gcc/13.3.1/p4est-2.8.7-3ohtcgz/lib/pkgconfig/
total 16
-rw-r--r-- 1 dom dom  394 Apr  3 08:24 libsc-2.8.7.pc
lrwxrwxrwx 1 dom dom   14 Apr  3 08:24 libsc.pc -> libsc-2.8.7.pc
-rw-r--r-- 1 dom dom  429 Apr  3 08:24 p4est-2.8.7.pc
lrwxrwxrwx 1 dom dom   14 Apr  3 08:24 p4est.pc -> p4est-2.8.7.pc
drwxr-sr-x 2 dom dom 4096 Apr  3 08:24 .
drwxr-sr-x 3 dom dom 4096 Apr  3 08:24 ..

@spackbot-app spackbot-app bot requested a review from davydden April 3, 2025 14:54
@climbfuji
Copy link
Copy Markdown
Contributor Author

climbfuji commented Apr 3, 2025

@cburstedde FYI

This was referenced Apr 3, 2025
Closed
Merged
@climbfuji climbfuji requested review from tldahlgren and removed request for davydden April 3, 2025 15:08
tldahlgren
tldahlgren approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checksum is valid.

@alecbcs alecbcs changed the title Add [email protected] p4est: add v2.8.7 Apr 3, 2025
@tldahlgren tldahlgren self-assigned this Apr 3, 2025
@tldahlgren
Copy link
Copy Markdown
Contributor

tldahlgren commented Apr 3, 2025

@climbfuji Is it okay to (enable the) merge? Or should I wait on @cburstedde?

@tldahlgren
Copy link
Copy Markdown
Contributor

tldahlgren commented Apr 3, 2025

@climbfuji Is it okay to (enable the) merge? Or should I wait on @cburstedde?

Actually, given the change, etc. I'm just going to merge it. There can be a follow on PR if there is any additional related work.

@tldahlgren tldahlgren enabled auto-merge (squash) April 3, 2025 17:18
@climbfuji
Copy link
Copy Markdown
Contributor Author

climbfuji commented Apr 3, 2025

@climbfuji Is it okay to (enable the) merge? Or should I wait on @cburstedde?

Actually, given the change, etc. I'm just going to merge it. There can be a follow on PR if there is any additional related work.

Yes please, thank you!

@climbfuji climbfuji mentioned this pull request Apr 3, 2025
Merged
7 tasks
@tldahlgren tldahlgren merged commit 72c1d00 into spack:develop Apr 4, 2025
17 checks passed
@climbfuji climbfuji deleted the feature/add_p4est_287_spack_dev branch April 4, 2025 11:32
climbfuji added a commit to climbfuji/spack that referenced this pull request Apr 17, 2025
@climbfuji
Add [email protected] (spack#49859)
d08ced0
@greenc-FNAL greenc-FNAL mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tldahlgren tldahlgren tldahlgren approved these changes

Assignees

@tldahlgren tldahlgren

Labels

new-version update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@climbfuji @tldahlgren