Merged
Conversation
spackbot-app
bot
added
commands
core
alalazo
force-pushed
the
parser/percent-parsed-as-caret
branch
from
fa9ddfe to
6ee75db
Compare
alalazo
force-pushed
the
parser/percent-parsed-as-caret
branch
from
6ee75db to
dc8399b
Compare
alalazo
force-pushed
the
parser/percent-parsed-as-caret
branch
from
4016765 to
1db90b5
Compare
tgamblin
requested changes
May 3, 2025
alalazo
force-pushed
the
parser/percent-parsed-as-caret
branch
3 times, most recently
from
4252e03 to
bb382cf
Compare
alalazo
force-pushed
the
parser/percent-parsed-as-caret
branch
2 times, most recently
from
a659b61 to
93e4e05
Compare
This commit modifies the parser, so that "%" is parsed as a DEPENDENCY, and all node properties that follow are associated to the name after the "%", e.g. in "foo %gcc +binutils" the "+binutils" refers to `gcc` and not to `foo` anymore. The "%" is still parsed as a build-only dependency. Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
force-pushed
the
parser/percent-parsed-as-caret
branch
from
93e4e05 to
6e37a54
Compare
tgamblin
requested changes
May 13, 2025
Member
tgamblin
left a comment
tgamblin
left a comment
There was a problem hiding this comment.
looks mostly good -- a couple change requests.
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Member
|
I've updated the top-level description to mention |
tgamblin
approved these changes
May 14, 2025
climbfuji
pushed a commit
to climbfuji/spack
that referenced
this pull request
May 15, 2025
This PR modifies the parser, so that `%` is parsed as a `DEPENDENCY`, and all node properties that follow are associated to the name after the `%`. e.g., in `foo %gcc +binutils` the `+binutils` refers to `gcc` and not to `foo`. `%` is still parsed as a build-type dependency, at the moment. Environments, config files and `package.py` files from before Spack v1.0 may have spec strings with package variants, targets, etc. *after* a build dependency, and these will need to be updated. You can use the `spack style --spec-strings` command to do this. To see what strings will be parsed differently under Spack v1.0, run: ``` spack style --spec-strings FILES ``` where `FILES` is a list of filenames that may contain old specs. To update these spec strings so that they parse correctly under both Spack 1.0 and Spack 0.x, you can run: ``` spack style --fix --spec-strings FILES ``` In the example above, `foo %gcc +binutils` would be rewritten as `foo +binutils %gcc`, which parses the same in any Spack version. In addition, this PR fixes several issues with `%` dependencies: - [x] Ensure we can still constrain compilers on reuse - [x] Ensure we can reuse a compiler by hash - [x] Add tests --------- Signed-off-by: Massimiliano Culpo <[email protected]>
3 tasks
jezwilkinson
pushed a commit
to jezwilkinson/spack
that referenced
this pull request
May 20, 2025
This PR modifies the parser, so that `%` is parsed as a `DEPENDENCY`, and all node properties that follow are associated to the name after the `%`. e.g., in `foo %gcc +binutils` the `+binutils` refers to `gcc` and not to `foo`. `%` is still parsed as a build-type dependency, at the moment. Environments, config files and `package.py` files from before Spack v1.0 may have spec strings with package variants, targets, etc. *after* a build dependency, and these will need to be updated. You can use the `spack style --spec-strings` command to do this. To see what strings will be parsed differently under Spack v1.0, run: ``` spack style --spec-strings FILES ``` where `FILES` is a list of filenames that may contain old specs. To update these spec strings so that they parse correctly under both Spack 1.0 and Spack 0.x, you can run: ``` spack style --fix --spec-strings FILES ``` In the example above, `foo %gcc +binutils` would be rewritten as `foo +binutils %gcc`, which parses the same in any Spack version. In addition, this PR fixes several issues with `%` dependencies: - [x] Ensure we can still constrain compilers on reuse - [x] Ensure we can reuse a compiler by hash - [x] Add tests --------- Signed-off-by: Massimiliano Culpo <[email protected]>
abhishek1297
pushed a commit
to abhishek1297/spack-melissa
that referenced
this pull request
May 22, 2025
This PR modifies the parser, so that `%` is parsed as a `DEPENDENCY`, and all node properties that follow are associated to the name after the `%`. e.g., in `foo %gcc +binutils` the `+binutils` refers to `gcc` and not to `foo`. `%` is still parsed as a build-type dependency, at the moment. Environments, config files and `package.py` files from before Spack v1.0 may have spec strings with package variants, targets, etc. *after* a build dependency, and these will need to be updated. You can use the `spack style --spec-strings` command to do this. To see what strings will be parsed differently under Spack v1.0, run: ``` spack style --spec-strings FILES ``` where `FILES` is a list of filenames that may contain old specs. To update these spec strings so that they parse correctly under both Spack 1.0 and Spack 0.x, you can run: ``` spack style --fix --spec-strings FILES ``` In the example above, `foo %gcc +binutils` would be rewritten as `foo +binutils %gcc`, which parses the same in any Spack version. In addition, this PR fixes several issues with `%` dependencies: - [x] Ensure we can still constrain compilers on reuse - [x] Ensure we can reuse a compiler by hash - [x] Add tests --------- Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
added a commit
that referenced
this pull request
May 29, 2025
Following #49808 this PR removes the default dependency type attached to the % sigil, so that ^ and % have a symmetric behavior. Modifications: * Modify Spec.satisfies to account for different deptypes attached to % * Modify the solver to avoid assuming % refers to a "build only" deptype * Allow solving %[deptypes=link] mpich etc. Signed-off-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the parser, so that
%is parsed as aDEPENDENCY, and all node properties that follow are associated to the name after the%. e.g., infoo %gcc +binutilsthe+binutilsrefers togccand not tofoo.%is still parsed as a build-type dependency, at the moment.Environments, config files and
package.pyfiles from before Spack v1.0 may have spec strings with package variants, targets, etc. after a build dependency, and these will need to be updated. You can use thespack style --spec-stringscommand to do this.To see what strings will be parsed differently under Spack v1.0, run:
where
FILESis a list of filenames that may contain old specs. To update these spec strings so that they parse correctly under both Spack 1.0 and Spack 0.x, you can run:In the example above,
foo %gcc +binutilswould be rewritten asfoo +binutils %gcc,which parses the same in any Spack version.
In addition, this PR fixes several issues with
%dependencies: